Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] ARM64 artifacts for testing #641

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 12, 2021

Description

Removing the graceful failures for ARM64 snapshot testing and
updating tests.

Previously, snapshots for ARM64 were not available but now they are
so this allows developers to run tests for that arch out of the box
whereas before they had to set the snapshot manually.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

Partial: #475

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Removing the graceful failures for ARM64 snapshot testing and
updating tests.

Previously, snapshots for ARM64 were not available but now they are
so this allows developers to run tests for that arch out of the box
whereas before they had to set the snapshot manually.

Partially resolves:
opensearch-project#475

Signed-off-by: Kawika Avilla <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 0c63142

Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Did you run the tests on ARM?

@kavilla
Copy link
Member Author

kavilla commented Jul 12, 2021

Screen Shot 2021-07-12 at 11 07 59 AM

Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Rocky! 🪨

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks rocky

@kavilla kavilla merged commit 30536cf into opensearch-project:main Jul 13, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jul 26, 2021
Removing the graceful failures for ARM64 snapshot testing and
updating tests.

Previously, snapshots for ARM64 were not available but now they are
so this allows developers to run tests for that arch out of the box
whereas before they had to set the snapshot manually.

Partially resolves:
opensearch-project#475

Backport PR:
opensearch-project#641

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jul 28, 2021
Removing the graceful failures for ARM64 snapshot testing and
updating tests.

Previously, snapshots for ARM64 were not available but now they are
so this allows developers to run tests for that arch out of the box
whereas before they had to set the snapshot manually.

Partially resolves:
#475

Backport PR:
#641

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants