-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] ARM64 artifacts for testing #641
[Tests] ARM64 artifacts for testing #641
Conversation
Removing the graceful failures for ARM64 snapshot testing and updating tests. Previously, snapshots for ARM64 were not available but now they are so this allows developers to run tests for that arch out of the box whereas before they had to set the snapshot manually. Partially resolves: opensearch-project#475 Signed-off-by: Kawika Avilla <[email protected]>
✅ DCO Check Passed 0c63142 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Did you run the tests on ARM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Rocky! 🪨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks rocky
Removing the graceful failures for ARM64 snapshot testing and updating tests. Previously, snapshots for ARM64 were not available but now they are so this allows developers to run tests for that arch out of the box whereas before they had to set the snapshot manually. Partially resolves: opensearch-project#475 Backport PR: opensearch-project#641 Signed-off-by: Kawika Avilla <[email protected]>
Removing the graceful failures for ARM64 snapshot testing and updating tests. Previously, snapshots for ARM64 were not available but now they are so this allows developers to run tests for that arch out of the box whereas before they had to set the snapshot manually. Partially resolves: #475 Backport PR: #641 Signed-off-by: Kawika Avilla <[email protected]>
Description
Removing the graceful failures for ARM64 snapshot testing and
updating tests.
Previously, snapshots for ARM64 were not available but now they are
so this allows developers to run tests for that arch out of the box
whereas before they had to set the snapshot manually.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
Partial: #475
Check List