Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition charts with legend and tooltip #532

Closed
wylieconlon opened this issue Jan 30, 2020 · 3 comments · Fixed by #616
Closed

Partition charts with legend and tooltip #532

wylieconlon opened this issue Jan 30, 2020 · 3 comments · Fixed by #616
Assignees
@markov00
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :tooltip Related to hover tooltip

Comments

@wylieconlon
Copy link

Legends and tooltips are a requirement for replacing pie and donut charts in Kibana. The main reason is that when rendered in a dashboard, it's not obvious what the visualization shows without the tooltip to indicate the source of the data.

The legend and coloring implementation that exists in Kibana combines all values into a flat legend, regardless of the layer it's displayed on. That behavior might not be needed if we can come up with a better way of displaying legends.

Screenshot 2020-01-30 14 27 50

Screenshot 2020-01-30 14 28 42

While there are customization options in the current implementation, they are pretty minimal. For example, the legend can't be hidden.
Screenshot 2020-01-30 14 29 46
@wylieconlon wylieconlon added enhancement New feature or request :legend Legend related issue :tooltip Related to hover tooltip labels Jan 30, 2020
@wylieconlon wylieconlon mentioned this issue Jan 30, 2020
Merged
2 tasks
@markov00 markov00 self-assigned this Mar 27, 2020
@wylieconlon
Copy link
Author

To break down this feature more, I think there are a few elements:

  • Color legend for the first layer is a requirement for us in Lens. Because we are using color on the first layer to indicate category, this would be enough for our use. The first layer is often too small to show labels inside the slices or rectangles, but the color matters a lot. Because of these limitations, a one-level legend would be enough.
  • Supporting some kind of nested legend is a nice-to-have, but I understand it's a harder problem.
  • I think tooltips that show "field" and "value" as seen in the screenshot would be nice to have.

@wylieconlon wylieconlon mentioned this issue Mar 27, 2020
Open
17 tasks
@markov00 markov00 mentioned this issue Apr 9, 2020
Closed
1 task
@markov00
Copy link
Member

markov00 commented Apr 9, 2020

I've opened #623 for the tooltip request

@markov00 markov00 mentioned this issue Apr 9, 2020
Merged
4 tasks
markov00 added a commit that referenced this issue Apr 14, 2020
@markov00
feat(partition): add legend and highlighters (#616)
6a4247e 
This commit adds the legend and highlighters to partition charts.
Two new options are added to the <Settings/> components: `flatLegend` will flat the legend for pie/tree hierarchical legend and `legendMaxDepth` will limit the legend hierarchy to a maximum depth value: 1 is the root level (can be combined with the `flatLegend`).

close #486, close #532
markov00 pushed a commit that referenced this issue Apr 15, 2020
@semantic-release-bot
chore(release): 18.3.0 [skip ci]
1e3a130 
# [18.3.0](v18.2.2...v18.3.0) (2020-04-15)

### Bug Fixes

* remove series with undefined splitSeriesAccessor values ([#627](#627)) ([59f0f6e](59f0f6e))

### Features

* gauge, goal and bullet graph (alpha) ([#614](#614)) ([5669178](5669178))
* **partition:** add legend and highlighters ([#616](#616)) ([6a4247e](6a4247e)), closes [#486](#486) [#532](#532)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 18.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 15, 2020
@nickofthyme nickofthyme mentioned this issue Apr 16, 2020
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 18.3.0 [skip ci]
784ff64 
# [18.3.0](elastic/elastic-charts@v18.2.2...v18.3.0) (2020-04-15)

### Bug Fixes

* remove series with undefined splitSeriesAccessor values ([opensearch-project#627](elastic/elastic-charts#627)) ([e8bd5ea](elastic/elastic-charts@e8bd5ea))

### Features

* gauge, goal and bullet graph (alpha) ([opensearch-project#614](elastic/elastic-charts#614)) ([4191664](elastic/elastic-charts@4191664))
* **partition:** add legend and highlighters ([opensearch-project#616](elastic/elastic-charts#616)) ([b939596](elastic/elastic-charts@b939596)), closes [opensearch-project#486](elastic/elastic-charts#486) [opensearch-project#532](elastic/elastic-charts#532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(partition): add legend and highlighters markov00/elastic-charts
2 participants
@wylieconlon @markov00