This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Consolidate go modules to top level directory (bp #954) #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mergify
bot
added
the
conflicts
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 136 |
| Skipped | 0 |
| Total | 137 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / Deploying a default stand-alone agent – Stand-alone Agent
mdelapenya
removed
the
conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #954 done by Mergify.
Cherry-pick of e0617f3 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/