This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Consolidate go modules to top level directory #954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]>
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 2 |
Passed | 135 |
Skipped | 0 |
Total | 137 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / Un-installing the installed centos agent – Backend Processes
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / Un-installing the installed centos agent – Fleet Mode Agent
mdelapenya
reviewed
Mar 29, 2021
mdelapenya
reviewed
Mar 29, 2021
Co-authored-by: Manuel de la Peña <[email protected]>
This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]>
Signed-off-by: Adam Stokes <[email protected]>
Filed this bug to see what if anything could be done with the import errors: elastic/apm-agent-go#922 |
We'd need to consolidate the NOTICE process too |
For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]>
@mdelapenya This is now ready for review, go imports fixed as well |
mdelapenya
approved these changes
Mar 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mdelapenya
added a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers who utilize things such as language server protocol to
easily resolve package level signatures across similar modules that make up the
project.
Signed-off-by: Adam Stokes [email protected]
What does this PR do?
Moves go modules to the top level directory and each sub directory will reference those imports during build/run phases
Why is it important?
Gives better developer experience when utilizing linting, language protocols for definition reference, etc
Checklist
make notice
in the proper directory)Author's Checklist
How to test this PR locally
Related issues