This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Merge CLI and e2e dirs into the root dir #557
Comments
|
@jsoriano I'd like to know your opinion about how to address this, as you have more experience with larger Go codebases and layouts. |
What kind of issues are you having with current layout? |
|
Linting in precommit causes many false positives, see https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/master/92/tests (Sanity checks section). Also VSCode many times has hard times with IntelliSense for autocomplete and lint, not sure if it's because of the multi-module project. |
8 tasks
adam-stokes
added a commit
that referenced
this issue
Mar 29, 2021
This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]>
8 tasks
mdelapenya
added a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mergify bot
pushed a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mergify bot
pushed a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mergify bot
pushed a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum
mdelapenya
added a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this issue
Mar 30, 2021
* Consolidate go modules to top level directory (#954) * Consolidate go modules to top level directory This allows developers who utilize things such as language server protocol to easily resolve package level signatures across similar modules that make up the project. Fixes #557 Signed-off-by: Adam Stokes <[email protected]> * Update go.mod Co-authored-by: Manuel de la Peña <[email protected]> * Remove e2e-testing modules from go.mod This was causing some invalid import errors Signed-off-by: Adam Stokes <[email protected]> * add proper godog deps Signed-off-by: Adam Stokes <[email protected]> * Address issue with godog import For now it is recommended to use the latest commit hash from go.elastic.co/apm until the next official release is out. That release cleans up some internals in that project making godog not a hard requirement when using apm as a dependency Signed-off-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> (cherry picked from commit e0617f3) # Conflicts: # cli/go.mod # cli/go.sum * chore: remove files after merge conflicts Co-authored-by: Adam Stokes <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This will prevent for false positives when linting
The text was updated successfully, but these errors were encountered: