-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] httpjson input set Content-Type correctly #24336
Merged
leehinman
merged 1 commit into
elastic:master
from
leehinman:24331_form-urlencoded_not_set
Mar 8, 2021
Merged
[Filebeat] httpjson input set Content-Type correctly #24336
leehinman
merged 1 commit into
elastic:master
from
leehinman:24331_form-urlencoded_not_set
Mar 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 4, 2021
leehinman
added
bug
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:Security-External Integrations
labels
Mar 4, 2021
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 4, 2021
leehinman
force-pushed
the
24331_form-urlencoded_not_set
branch
from
March 4, 2021 02:51
1db1730
to
fd51a58
Compare
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leehinman
force-pushed
the
24331_form-urlencoded_not_set
branch
from
March 4, 2021 14:15
fd51a58
to
38c2d00
Compare
marc-gr
approved these changes
Mar 8, 2021
6 tasks
4 tasks
leehinman
added
v7.13.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 8, 2021
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Mar 8, 2021
Closes elastic#24331 (cherry picked from commit 4f5c282)
4 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Mar 8, 2021
Closes elastic#24331 (cherry picked from commit 4f5c282)
leehinman
added a commit
that referenced
this pull request
Mar 8, 2021
leehinman
added a commit
that referenced
this pull request
Mar 8, 2021
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) Closes elastic#24331 (cherry picked from commit 30148c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when using encode_as "application/x-www-form-urlencoded" option in
httpjson input, the Content-Type is now set correctly to
"application/x-www-form-urlencoded"
Why is it important?
Content-Type header should match the actual content type
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues