Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] httpjson input set Content-Type correctly #24336

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

leehinman
Copy link
Contributor

What does this PR do?

when using encode_as "application/x-www-form-urlencoded" option in
httpjson input, the Content-Type is now set correctly to
"application/x-www-form-urlencoded"

Why is it important?

Content-Type header should match the actual content type

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

mage goUnitTest

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2021
@leehinman leehinman added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Mar 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2021
@leehinman leehinman force-pushed the 24331_form-urlencoded_not_set branch from 1db1730 to fd51a58 Compare March 4, 2021 02:51
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24336 updated

  • Start Time: 2021-03-04T14:16:18.231+0000

  • Duration: 59 min 56 sec

  • Commit: 38c2d00

Test stats 🧪

Test Results
Failed 0
Passed 6841
Skipped 1153
Total 7994

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6841
Skipped 1153
Total 7994

@leehinman leehinman force-pushed the 24331_form-urlencoded_not_set branch from fd51a58 to 38c2d00 Compare March 4, 2021 14:15
@leehinman leehinman requested a review from marc-gr March 4, 2021 14:16
@marc-gr marc-gr mentioned this pull request Mar 8, 2021
6 tasks
@leehinman leehinman merged commit 4f5c282 into elastic:master Mar 8, 2021
@leehinman leehinman added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 8, 2021
leehinman added a commit to leehinman/beats that referenced this pull request Mar 8, 2021
leehinman added a commit to leehinman/beats that referenced this pull request Mar 8, 2021
@leehinman leehinman deleted the 24331_form-urlencoded_not_set branch March 8, 2021 16:06
leehinman added a commit that referenced this pull request Mar 8, 2021
leehinman added a commit that referenced this pull request Mar 8, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat httpjson v2 input should set Content-Type header to match to specified encoder
3 participants