Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24336 to 7.12: [Filebeat] httpjson input set Content-Type correctly #24422

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Mar 8, 2021

Cherry-pick of PR #24336 to 7.12 branch. Original message:

What does this PR do?

when using encode_as "application/x-www-form-urlencoded" option in
httpjson input, the Content-Type is now set correctly to
"application/x-www-form-urlencoded"

Why is it important?

Content-Type header should match the actual content type

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

mage goUnitTest

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 8, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24422 opened

  • Start Time: 2021-03-08T16:07:21.844+0000

  • Duration: 50 min 19 sec

  • Commit: 2979edc

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

@leehinman leehinman merged commit af32fef into elastic:7.12 Mar 8, 2021
@leehinman leehinman deleted the backport_24336_7.12 branch March 11, 2021 14:30
@zube zube bot removed the [zube]: Done label Jun 7, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants