Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo on using form encoding #24329

Closed
wants to merge 1 commit into from
Closed

Fixes typo on using form encoding #24329

wants to merge 1 commit into from

Conversation

dcode
Copy link
Contributor

@dcode dcode commented Mar 3, 2021

What does this PR do?

The documentation for using form encoding had a typo on how to specify it. I corrected it to what is listed in the beats source.

Why is it important?

Correct docs make sure users don't have to read the code to guess how it works.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@dcode dcode requested review from P1llus and leehinman March 3, 2021 22:01
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24329 opened

  • Start Time: 2021-03-03T22:00:37.374+0000

  • Duration: 20 min 51 sec

  • Commit: 355cea1

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@leehinman
Copy link
Contributor

🤦 thanks for catching this. Would you mind doing PR against master and I'll backport to 7.12

@marc-gr
Copy link
Contributor

marc-gr commented Mar 8, 2021

Is this change duplicated in #24336 @leehinman? Maybe we can close this if so if we backport it.

@leehinman
Copy link
Contributor

closing because #24336 covers it.

@leehinman leehinman closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants