-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use indexers and matchers in config when defaults are enabled #18818
Use indexers and matchers in config when defaults are enabled #18818
Conversation
Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future.
Pinging @elastic/integrations-platforms (Team:Platforms) |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Chris Mark <[email protected]>
…c#18818) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
…c#18818) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
…c#18818) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
…-stage-level * upstream/master: (30 commits) Add a GRPC listener service for Agent (elastic#18827) Disable host.* fields by default for iptables module (elastic#18756) [WIP] Clarify capabilities of the Filebeat auditd module (elastic#17068) fix: rename file and remove extra separator (elastic#18881) ci: enable JJBB (elastic#18812) Disable host.* fields by default for Checkpoint module (elastic#18754) Disable host.* fields by default for Cisco module (elastic#18753) Update latest.yml testing env to 7.7.0 (elastic#18535) Upgrade k8s.io/client-go and k8s keystore tests (elastic#18817) Add missing Jenkins stages for Auditbeat (elastic#18835) [Elastic Log Driver] Create a config shim between libbeat and the user (elastic#18605) Use indexers and matchers in config when defaults are enabled (elastic#18818) Fix panic on `metricbeat test modules` (elastic#18797) [CI] Fix permissions in MacOSX agents (elastic#18847) [Ingest Manager] When not port are specified and the https is used fallback to 443 (elastic#18844) [Ingest Manager] Fix install service script for windows (elastic#18814) [Metricbeat] Fix getting compute instance metadata with partial zone/region config (elastic#18757) Improve error messages in s3 input (elastic#18824) Add memory metrics into compute googlecloud (elastic#18802) include bucket name when logging error (elastic#18679) ...
#18856) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
#18857) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
#18859) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
When using the Kubernetes add metadata processor, the error `Error extracting container id - source value does not contain matcher's logs_path` might be reported in some cases. Typical issues: - The `logs_path` is incorrect - We had some problems in the past (7.7.0) due to a change in behavior (#18818), which was restored in 7.7.2 onwards. - The Kubernetes pod is crashing
…c#18818) (elastic#18859) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 5c65f6d) Co-authored-by: Chris Mark <[email protected]>
Before 7.7.0, indexers and matchers defined in
add_kubernetes_metadata
configuration were used even when defaults were not disabled. Revert to
this behaviour and add tests to avoid changing it unexpectedly in the
future.
Reverts part of #16979, fixes #18481.