Cherry-pick #18818 to 7.8: Use indexers and matchers in config when defaults are enabled #18857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
…c#18818) Before 7.7.0, indexers and matchers defined in `add_kubernetes_metadata` configuration were used even when defaults were not disabled. Revert to this behaviour and add tests to avoid changing it unexpectedly in the future. (cherry picked from commit 600998b) Co-authored-by: Chris Mark <[email protected]>
jsoriano
force-pushed
the
backport_18818_7.8
branch
from
11f48b8 to
13b1985
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
ChrsMark
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18818 to 7.8 branch. Original message:
Before 7.7.0, indexers and matchers defined in
add_kubernetes_metadataconfiguration were used even when defaults were not disabled. Revert to
this behaviour and add tests to avoid changing it unexpectedly in the
future.
Reverts part of #16979, fixes #18481.