Add memory metrics into compute googlecloud #18802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kaiyan-sheng
added
Metricbeat
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
approved these changes
May 28, 2020
| - `instance_name`: The name of the VM instance. | ||
|
|
||
| * `instance.memory.balloon.swap_out_bytes_count`: The amount of memory written from the guest to its own swap space. This metric is only available for VMs that belong to the e2 family. | ||
| - `instance_name`: The name of the VM instance. |
There was a problem hiding this comment.
How are you generating this list of metrics? I find it a bit redundant with metricbeat/docs/fields.asciidoc. If we feel the need of having the metrics descriptions in two places maybe we have to rethink how we generate these docs.
In any case they should be auto-generated from the fields.yml files, so we only have to maintain the descriptions in one place.
There was a problem hiding this comment.
I'm manually copying these fields in here so it can be displayed on individual metricset doc: https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-metricset-googlecloud-compute.html
Good point! I shouldn't have to copy paste these descriptions twice and maintain in two different places. Maybe in the doc, I should just display x-pack/metricbeat/module/googlecloud/compute/_meta/fields.yml instead?
There was a problem hiding this comment.
There is already a link to exported fields in the metricset docs.
But the one for this module seems quite empty: https://www.elastic.co/guide/en/beats/metricbeat/current/exported-fields-googlecloud.html
We will have to review this. If we think that the fields should appear directly in the metricset docs page, we should generate them automatically there. If we want to continue using the separated page we will have to check why the fields of this module doesn't appear there.
There was a problem hiding this comment.
There is an old issue discussing about fields descriptions in docs: #9288
There was a problem hiding this comment.
Thank you! I will create a separate PR to fix the exported fields section.
| - `instance_name`: The name of the VM instance. | ||
|
|
||
| * `instance.memory.balloon.swap_in_bytes_count`: The amount of memory read into the guest from its own swap space. This metric is only available for VMs that belong to the e2 family. | ||
| - `instance_name`: The name of the VM instance. |
There was a problem hiding this comment.
Why is this instance_name repeated in all metrics?
There was a problem hiding this comment.
instance_name is label that comes with these metrics, like a default dimension in gcp.
jsoriano
reviewed
May 28, 2020
| - "compute.googleapis.com/instance/network/received_bytes_count" | ||
| - "compute.googleapis.com/instance/network/received_packets_count" | ||
| - "compute.googleapis.com/instance/network/sent_bytes_count" | ||
| - "compute.googleapis.com/instance/network/sent_packets_count" |
|
Oh, btw, before merging please remember to add a changelog entry. |
|
Failure in CI can be ignored, it is related to #18741 |
jsoriano
approved these changes
May 28, 2020
kaiyan-sheng
added
v7.9.0
and removed
needs_backport
kaiyan-sheng
added a commit
that referenced
this pull request
May 29, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
May 29, 2020
…ric into compute googlecloud (#18834)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 2, 2020
…-stage-level * upstream/master: (30 commits) Add a GRPC listener service for Agent (elastic#18827) Disable host.* fields by default for iptables module (elastic#18756) [WIP] Clarify capabilities of the Filebeat auditd module (elastic#17068) fix: rename file and remove extra separator (elastic#18881) ci: enable JJBB (elastic#18812) Disable host.* fields by default for Checkpoint module (elastic#18754) Disable host.* fields by default for Cisco module (elastic#18753) Update latest.yml testing env to 7.7.0 (elastic#18535) Upgrade k8s.io/client-go and k8s keystore tests (elastic#18817) Add missing Jenkins stages for Auditbeat (elastic#18835) [Elastic Log Driver] Create a config shim between libbeat and the user (elastic#18605) Use indexers and matchers in config when defaults are enabled (elastic#18818) Fix panic on `metricbeat test modules` (elastic#18797) [CI] Fix permissions in MacOSX agents (elastic#18847) [Ingest Manager] When not port are specified and the https is used fallback to 443 (elastic#18844) [Ingest Manager] Fix install service script for windows (elastic#18814) [Metricbeat] Fix getting compute instance metadata with partial zone/region config (elastic#18757) Improve error messages in s3 input (elastic#18824) Add memory metrics into compute googlecloud (elastic#18802) include bucket name when logging error (elastic#18679) ...
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…unt metric into compute googlecloud (elastic#18834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add 4 memory metrics(only for e2 family VMs) into googlecloud compute metricset and also added the missing
network.sent_packets_countmetric.