This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
fix: --opbeans-node-agent-local-repo=/a/local/dir #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes './scripts/compose.py start --opbeans-node-agent-local-repo=$dir' to (a) install the Node.js APM agent into the opbeans-node app at "/app" and (b) to skip copying the possibly large node_modules and build dirs for speed. Fixes: elastic#1083
trentm
commented
Mar 22, 2021
| echo "Installing from local folder" | ||
| # copy to folder inside container to ensure were not poluting the local folder | ||
| cp -r /local-install ~ | ||
| cd ~/local-install && npm install . |
There was a problem hiding this comment.
This npm install . was installing the deps for the apm-agent-nodejs copy in ~/local-install, but it wasn't installing them where the app at "/app" would use it.
trentm
commented
Mar 22, 2021
docker/opbeans/node/entrypoint.sh
Outdated
| echo "Installing elastic-apm-node from local folder (--opbeans-node-agent-local-repo)" | ||
| # Copy to a folder inside container to ensure we're not polluting the | ||
| # local folder. Skip possibly huge dirs to speed this up. | ||
| apk add rsync |
There was a problem hiding this comment.
Is installing rsync appropriate here? Would doing so in the Dockerfile be more appropriate?
There was a problem hiding this comment.
it is better to add packages on the Dockerfile
…epo, it should work fine now
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
v1v
approved these changes
Mar 23, 2021
kuisathaverat
approved these changes
Mar 23, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Mar 29, 2021
…rt-from-build * upstream/master: (24 commits) Add mergify (elastic#1089) fix: update flake8 and deps to work with Python 3.8+ (elastic#1085) chore: bump elastic stack (elastic#1087) fix: force to activate venv (elastic#1086) fix: --opbeans-node-agent-local-repo=/a/local/dir (elastic#1084) ci: jjbb remove periodic-folder-trigger (elastic#1079) Fix APM Server managed by Elastic Agent setup (elastic#1078) docker/opbeans/go: use -mod=mod (elastic#1077) [fleet] fix elastic-agent setup (elastic#1076) update supported stack versions (elastic#1075) [CI] Increase timeout (elastic#1070) Add --package-registry-url flag (elastic#1069) Create opbeans_user/role with write/read access for the opbeans-python (elastic#1063) reset postgres sequences after database migration (elastic#1062) chore: bump Elastic Stack (elastic#1060) docker/go/nethttp: go build -mod=mod (elastic#1061) check agent liveness via version subcommand (elastic#1059) test: use filebeat step to grab Docker logs (elastic#1029) Update dotnet sdk 5.0 docker image (elastic#1048) docs: using Dyno (elastic#1056) ...
trentm
added a commit
to trentm/apm-integration-testing
that referenced
this pull request
Apr 28, 2021
Fixes './scripts/compose.py start --opbeans-node-agent-local-repo=$dir' to (a) install the Node.js APM agent into the opbeans-node app at "/app" and (b) to skip copying the possibly large node_modules and build dirs for speed. Fixes: elastic#1083 # Conflicts: # README.md
trentm
added a commit
that referenced
this pull request
Apr 28, 2021
Fixes './scripts/compose.py start --opbeans-node-agent-local-repo=$dir' to (a) install the Node.js APM agent into the opbeans-node app at "/app" and (b) to skip copying the possibly large node_modules and build dirs for speed. Fixes: #1083 # Conflicts: # README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes './scripts/compose.py start --opbeans-node-agent-local-repo=$dir'
to (a) install the Node.js APM agent into the opbeans-node app at "/app"
and (b) to skip copying the possibly large node_modules and build dirs
for speed.
Why is it important?
Otherwise the starting of the opbeans-node container is potentially very slow and doesn't run the Node.js APM agent code one expects.
Related issues
Fixes: #1083