You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a --package-registry-url flag to control the Elastic Package Registry URL passed into the managed APM Server service and Kibana service environment variables.
Also, set XPACK_FLEET_REGISTRYURL in the Kibana environment (consistently with APM Server) regardless of whether we're using a local package registry or not.
Remove the dependency from APM Server to the local package registry; there is already a transitive dependency through Kibana.
Why is it important?
When running build candidates in the future we should probably default to running with the production Elastic Package Registry (epr.elastic.co). We will need to test with snapshots and staging though, so we can test with packages before they're promoted.
@jalvz it is very similar, but that one just controls the local package registry. It could be useful to run a proxy between Kibana and EPR, so I think we should allow a full URL to be specified. Maybe in another PR we could change the --package-registry-distribution flag to control the default value for EPR as well as the local distribution.
Only set when passing --snapshot, --enable-package-registry,
or --package-registry-url. Otherwise, rely on the default
registry URL for the stack version.
…rt-from-build
* upstream/master: (24 commits)
Add mergify (elastic#1089)
fix: update flake8 and deps to work with Python 3.8+ (elastic#1085)
chore: bump elastic stack (elastic#1087)
fix: force to activate venv (elastic#1086)
fix: --opbeans-node-agent-local-repo=/a/local/dir (elastic#1084)
ci: jjbb remove periodic-folder-trigger (elastic#1079)
Fix APM Server managed by Elastic Agent setup (elastic#1078)
docker/opbeans/go: use -mod=mod (elastic#1077)
[fleet] fix elastic-agent setup (elastic#1076)
update supported stack versions (elastic#1075)
[CI] Increase timeout (elastic#1070)
Add --package-registry-url flag (elastic#1069)
Create opbeans_user/role with write/read access for the opbeans-python (elastic#1063)
reset postgres sequences after database migration (elastic#1062)
chore: bump Elastic Stack (elastic#1060)
docker/go/nethttp: go build -mod=mod (elastic#1061)
check agent liveness via version subcommand (elastic#1059)
test: use filebeat step to grab Docker logs (elastic#1029)
Update dotnet sdk 5.0 docker image (elastic#1048)
docs: using Dyno (elastic#1056)
...
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
--package-registry-urlflag to control the Elastic Package Registry URL passed into the managed APM Server service and Kibana service environment variables.Also, set
XPACK_FLEET_REGISTRYURLin the Kibana environment (consistently with APM Server) regardless of whether we're using a local package registry or not.Remove the dependency from APM Server to the local package registry; there is already a transitive dependency through Kibana.
Why is it important?
When running build candidates in the future we should probably default to running with the production Elastic Package Registry (epr.elastic.co). We will need to test with snapshots and staging though, so we can test with packages before they're promoted.
Related issues
Closes #1068