This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
docker/go/nethttp: go build -mod=mod #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16 changed the "go build" command so that it no longer automatically updates go.mod and go.sum. Because we dynamically change the Go agent version, we cannot set go.mod and go.sum ahead of time. Pass in `-mod=mod` to reinstate the old behaviour.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
v1v
pushed a commit
to v1v/apm-integration-testing
that referenced
this pull request
Feb 23, 2021
Go 1.16 changed the "go build" command so that it no longer automatically updates go.mod and go.sum. Because we dynamically change the Go agent version, we cannot set go.mod and go.sum ahead of time. Pass in `-mod=mod` to reinstate the old behaviour.
v1v
added a commit
that referenced
this pull request
Feb 23, 2021
Go 1.16 changed the "go build" command so that it no longer automatically updates go.mod and go.sum. Because we dynamically change the Go agent version, we cannot set go.mod and go.sum ahead of time. Pass in `-mod=mod` to reinstate the old behaviour. Co-authored-by: Andrew Wilkins <[email protected]>
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Mar 29, 2021
…rt-from-build * upstream/master: (24 commits) Add mergify (elastic#1089) fix: update flake8 and deps to work with Python 3.8+ (elastic#1085) chore: bump elastic stack (elastic#1087) fix: force to activate venv (elastic#1086) fix: --opbeans-node-agent-local-repo=/a/local/dir (elastic#1084) ci: jjbb remove periodic-folder-trigger (elastic#1079) Fix APM Server managed by Elastic Agent setup (elastic#1078) docker/opbeans/go: use -mod=mod (elastic#1077) [fleet] fix elastic-agent setup (elastic#1076) update supported stack versions (elastic#1075) [CI] Increase timeout (elastic#1070) Add --package-registry-url flag (elastic#1069) Create opbeans_user/role with write/read access for the opbeans-python (elastic#1063) reset postgres sequences after database migration (elastic#1062) chore: bump Elastic Stack (elastic#1060) docker/go/nethttp: go build -mod=mod (elastic#1061) check agent liveness via version subcommand (elastic#1059) test: use filebeat step to grab Docker logs (elastic#1029) Update dotnet sdk 5.0 docker image (elastic#1048) docs: using Dyno (elastic#1056) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pass in
-mod=modto update go.mod/go.sum as necessary when building the Go "nethttp" test service.Why is it important?
Go 1.16 changed the "go build" command so that it no longer automatically updates go.mod and go.sum. See https://golang.org/doc/go1.16#go-command. Because we dynamically change the Go agent version, we cannot set go.mod and go.sum ahead of time.