Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS ECS/Fargate to container-info Parsing #2914

Closed
astorm opened this issue Sep 7, 2022 · 3 comments · Fixed by elastic/apm-nodejs-http-client#183 or #3008
Closed

Add AWS ECS/Fargate to container-info Parsing #2914

astorm opened this issue Sep 7, 2022 · 3 comments · Fixed by elastic/apm-nodejs-http-client#183 or #3008
Assignees
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone

Comments

@astorm
Copy link
Contributor

astorm commented Sep 7, 2022

Is your feature request related to a problem? Please describe.

We've identified a new pattern for pod UID strings. See spec PR.

Describe the solution you'd like

Update client parsing to include this new pattern. Also, consider pulling container-info module into either the client or agent project.

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 7, 2022
@trentm trentm changed the title Add AWS ECS/Faregate to container-info Parsing Add AWS ECS/Fargate to container-info Parsing Sep 8, 2022
@trentm
Copy link
Member

trentm commented Sep 20, 2022

When implementing this, we might also want to add testing based on the shared "json-specs/cgroup_parsing.json" added in elastic/apm#686

@trentm
Copy link
Member

trentm commented Sep 26, 2022

That shared spec file is being sync'd in in #2949

@estolfo estolfo added this to the 8.6 milestone Sep 27, 2022
@astorm astorm self-assigned this Sep 28, 2022
astorm added a commit to elastic/apm-nodejs-http-client that referenced this issue Oct 18, 2022
@trentm trentm reopened this Oct 18, 2022
@trentm
Copy link
Member

trentm commented Oct 18, 2022

Re-opened. This is only resolved when we update to a new release of 'elastic-apm-http-client' with the above commit.

trentm added a commit that referenced this issue Oct 27, 2022
…nfig re-fetch interval

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: #2914
Closes: #2941
trentm added a commit that referenced this issue Oct 27, 2022
…nfig re-fetch interval (#3008)

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: #2914
Closes: #2941
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this issue Aug 20, 2024
…nfig re-fetch interval (elastic#3008)

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: elastic#2914
Closes: elastic#2941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
3 participants