Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container-info for AWS ECS/Fargate; [5s,1d] guard on central config re-fetch interval #3008

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 27, 2022

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: #2914
Closes: #2941

…nfig re-fetch interval

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: #2914
Closes: #2941
@trentm trentm requested a review from astorm October 27, 2022 15:52
@trentm trentm self-assigned this Oct 27, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 27, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Oct 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-27T16:11:02.502+0000

  • Duration: 24 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 269774
Skipped 0
Total 269774

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 350e750 into main Oct 27, 2022
@trentm trentm deleted the trentm/update-client branch October 27, 2022 17:55
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…nfig re-fetch interval (elastic#3008)

Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.

Closes: elastic#2914
Closes: elastic#2941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
3 participants