-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend json-specs tests with cgroup-parsing #686
Conversation
9c814cf
to
9845f06
Compare
There are also quite a lot of other variants in Java agent test: https://github.com/elastic/apm-agent-java/blob/e9aacfdd2551dd52baae5881079c8597ea3d8cca/apm-agent-core/src/test/java/co/elastic/apm/agent/impl/metadata/ContainerInfoTest.java#L31 We could however add those in a follow-up PR when the Java agent has automated tests with this new JSON specification, but maybe if there are other parsed attributes it could be relevant to look at those too. |
Agreed, that sounds like a good follow-up once this PR is through. |
Hi @SylvainJuge are you fine with the PR in its current state or would you expect further changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, follow-up issues/PRs are expected once agents add those tests in their respective codebases.
This is a follow-up of #678 as suggested by @felixbarny in #678 (comment).
The existing tests in
apm-agent-dotnet
served as the source for thesejson-specs
test data.Once this PR is merged,
apm-dotnet-agent
will also switch to usingjson-specs
as input (FYI @gregkalapos).