Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for describing the application framework #69

Closed
axw opened this issue May 4, 2018 · 0 comments
Closed

Add support for describing the application framework #69

axw opened this issue May 4, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@axw
Copy link
Member

axw commented May 4, 2018

I'm currently removing the ability for specifying the framework in transaction payloads, because Go's web frameworks tend to be less exclusive of each other. i.e. you could have two web frameworks in the same application. When we can attach the framework info to the transaction, then we'll reinstate support.

This requires changes to the API and API server.

@axw axw added the enhancement New feature or request label May 4, 2018
axw added a commit to axw/apm-agent-go that referenced this issue May 4, 2018
Stop exposing the full service model in the
tracer - expose only the service name, version,
and environment instead. It is now no longer
possible to override the agent, language or
runtime; and it is no longer possible to set
the framework at all.

Framework is problematic because it doesn't
necessarily apply to all transactions, and
there's no way to attach the information at
the transaction level. So instead of including
it in a problematic state, we'll drop support
initially and work updates into the API and
server, and then reintroduce it later.

See elastic#69
@axw axw closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants