elasticapm: add Context.SetFramework #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #252 +/- ##
==========================================
+ Coverage 80.73% 80.76% +0.03%
==========================================
Files 92 92
Lines 5420 5481 +61
==========================================
+ Hits 4376 4427 +51
+ Misses 836 834 -2
- Partials 208 220 +12
Continue to review full report at Codecov.
|
Enable transactions and errors to override the service in their context. At the time of writing, the server merges back-to-front such that service-level overrides event-level, but even that's OK for our purposes as we will only set framework info in the transaction context, and never in service-level metadata.
Add a method for instrumentation to set the framework information for a transaction or error context.
Update apmecho, apmgin, and apmgrpc server middleware to set the framework info.
axw
force-pushed
the
v2-transaction-service-override
branch
from
c88ce31 to
804f997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method for instrumentation to set the framework information for a transaction or error context.
At the time of writing, the server merges back-to-front such that service-level overrides event-level, but that's OK for our purposes as we only set framework info in the transaction/error level, and never in service-level metadata.
Update apmecho, apmgin, and apmgrpc server middleware to set the framework info.
Closes #69