all: drop support for Service.Framework #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop exposing the full service model in the tracer - expose only the service name, version, and environment instead. It is now no longer possible to override the agent, language or runtime; and it is no longer possible to set the framework at all. Framework is problematic because it doesn't necessarily apply to all transactions, and there's no way to attach the information at the transaction level. So instead of including it in a problematic state, we'll drop support initially and work updates into the API and server, and then reintroduce it later. See elastic#69
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 74.05% 73.99% -0.06%
==========================================
Files 55 55
Lines 3079 3069 -10
==========================================
- Hits 2280 2271 -9
+ Misses 618 616 -2
- Partials 181 182 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop exposing the full service model in the
tracer - expose only the service name, version,
and environment instead. It is now no longer
possible to override the agent, language or
runtime; and it is no longer possible to set
the framework at all.
Framework is problematic because it doesn't
necessarily apply to all transactions, and
there's no way to attach the information at
the transaction level. So instead of including
it in a problematic state, we'll drop support
initially and work updates into the API and
server, and then reintroduce it later.
See #69