Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some Paella updates #1295

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Do some Paella updates #1295

merged 3 commits into from
Dec 18, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Dec 9, 2024

See commits.

Note that #1284 hasn't been fixed completely, which is probably due to me not realizing the extent of the problem and subsequently only talking about the captions menu in polimediaupv/paella-core#372.

@owi92 owi92 added changelog:user User facing changes area:player Paella and its integration in Tobira labels Dec 9, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1295 December 9, 2024 16:23 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1295 December 10, 2024 10:14 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1295 December 11, 2024 14:04 Destroyed
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Dec 12, 2024
@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Dec 12, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1295 December 12, 2024 16:38 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1295 December 13, 2024 10:05 Destroyed
@LukasKalbertodt
Copy link
Member

For the record, these are the differences:

Since I'm a bit lost: what exactly is this PR trying to solve? You link this one issue that's only partially fixed (what exactly is improved over the previous version?). But I think the timeline-separators are less blurry now or sth? But yeah, if you could list all the improvements I should see, that would be great :D

@owi92
Copy link
Member Author

owi92 commented Dec 18, 2024

Idk if I would say that this PR is "trying to solve" anything.
The updates reduce the height of the timeline separator, probably the blurryness as well. And the thing I mentioned in my top comment. I believe that's it.

@owi92
Copy link
Member Author

owi92 commented Dec 18, 2024

what exactly is improved over the previous version?

The thing that I wrote about in polimediaupv/paella-core#372.

@owi92
Copy link
Member Author

owi92 commented Dec 18, 2024

PS: Apparently #1047 is also fixed with this.

Edit: Ah no, it's not. I mixed this up with the background of the slides shown when hovering over the timeline.

@LukasKalbertodt
Copy link
Member

Ok so this improves at least a few things. The timeline separators are invisible for a few frames after opening the timeline, which is weird, but not too disruptive and can be fixed later.

@LukasKalbertodt LukasKalbertodt merged commit 3bd3e91 into elan-ev:next Dec 18, 2024
3 checks passed
@oas777
Copy link
Collaborator

oas777 commented Jan 3, 2025

When/where can I test this to check with the issues I have on my "Paella list"?

@oas777
Copy link
Collaborator

oas777 commented Jan 3, 2025

PS: Happy new year!

@owi92
Copy link
Member Author

owi92 commented Jan 3, 2025

@oas777 Happy new year.
We changed our branch structure back in November, since then you can test this and any "recently" merged PRs on https://next.tobira.opencast.org/.

@oas777
Copy link
Collaborator

oas777 commented Jan 3, 2025

Thanks, @owi92. I would summarize

Other observations:

  • German help texts in the control bar (visible upon hover-over) should all start with a capital letter, i. e. "Spielen" / "Pause" and "Zu Vollbild wechseln"; "Options" should be "Einstellungen"
  • Why are the presenter videos suddenly horizontal? Cf. https://next.tobira.opencast.org/!v/IwRRv4DvMtI vs. https://tinyurl.com/2cqc58hs.
  • There are up to eight (8!) icons in the video canvass for a dual video, can we deactivate (some of) them by default?
    grafik

@owi92
Copy link
Member Author

owi92 commented Jan 6, 2025

Thank you for the overview, Olaf. Regarding your summary:

Regarding your other observations:

  • I am fairly certain that the translations need to be fixed in paella. We cannot customize them in Tobira.
  • The video with the horizontal presenter video you have linked was cropped by Lukas. Other presenter videos should still have their original format.
  • Let's talk about the icons in our next meeting (and let's maybe try to keep it brief). It would be nice if you can suggest some icons to discard. If there are no objections from the others, I'll see to it.

LukasKalbertodt added a commit that referenced this pull request Jan 14, 2025
We already have slide previews and users can skip to sections using the
progress bar.
Suggested in
#1295 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:player Paella and its integration in Tobira changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants