Move SSH configuration into its own structure

[martina-if]

Move SSH configuration into it's own struct in preparation for #386

• Code compiles correctly (i.e make build)
• Added tests that cover your change (if possible)
• All unit tests passing (i.e. make test)
• Manually tested both the config file and the cli parameters
• Added/modified documentation as required (such as the README.md, and examples directory)

[errordeveloper]

Thanks @martina-if! Probably best get this in as-is and make the rest of changes for #386 in another PR.

[errordeveloper]

closes #386

There're quite a few things in that issue, do you want to make it all happen in one PR? Up to you.

To be clear, I think you'll need to change those string fields to *string, and make a few changes in key loader function, so that it respects PublicKey and PublicKeyName (as currently it doesn't).

[errordeveloper]

A few comments... I didn't read all of LoadSSHPublicKey just yet.

[errordeveloper]

🚢LGMT!

[phlukman]

hi @martina-if

I'm running version 0.1.29 and I'm configuring the yaml file as follows, according to the examples:

nodeGroups:

• name: security-cluster-ng1-public
  instanceType: t2.2xlarge
  desiredCapacity: 1
  ssh:
  publicKeyName: security-es-cluster-key
• name: security-cluster-ng2-private
  instanceType: t2.2xlarge
  desiredCapacity: 2
  privateNetworking: true
  ssh:
  publicKeyName: security-es-cluster-key

and I'm getting error:
[✖] loading config file "secure-cluster-config.yaml": error unmarshaling JSON: while decoding JSON: json: unknown field "ssh"

What am I missing here?

[martina-if]

Hi @phlukman,

The new ssh schema hasn't been released yet. We will make a release with those changes tomorrow at the latest. In the meantime try using it with the old schema, like this:

nodeGroups:
  - name: security-cluster-ng1-public
    instanceType: t2.2xlarge
    desiredCapacity: 1
    sshPublicKeyPath: security-es-cluster-key

  - name: security-cluster-ng2-private
    instanceType: t2.2xlarge
    desiredCapacity: 2
    privateNetworking: true
    sshPublicKeyPath: security-es-cluster-key

[phlukman]

thanks for your quick reply @martina-if !