Add reference value helpers for *bool and *string #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
value-ref-helpers
branch
from
d4555f4
to
98dad7c
Compare
martina-if
reviewed
Apr 9, 2019
martina-if
previously approved these changes
Apr 9, 2019
errordeveloper
force-pushed
the
value-ref-helpers
branch
from
98dad7c
to
ec27218
Compare
|
@martina-if could you please take another look? I also added another commit that fixes a minor case that we've missed in #673. I don't know if you might have fixed it in your other PR, I'm happy to drop the commit from here if you feel that we should. From the perspective of this PR that commit fixes integration tests. |
Actually, I said that too early! It's not true, the commit only fixes |
errordeveloper
force-pushed
the
value-ref-helpers
branch
from
ec27218
to
9adbb32
Compare
- renane `NewBoolTrue` & `NewBoolFalse` to `Enabled` `Disabled` - add `IsEnabled` and `IsDisabled` - add `IsSetAndNonEmptyString`
errordeveloper
force-pushed
the
value-ref-helpers
branch
from
9adbb32
to
209413b
Compare
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Remove arm overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds helper for checking if a
*stringvalue was set and isn't an empty string, as well as helpers for checking when a*boolvalue was set and is eithertrueorfalse.This is a follow-up to #673.
Checklist
make build)make test)All integration tests passing (i.e.- blocked by handling of default SSH with flags #720make integration-test)