Skip to content

Commit

Permalink
Rename SSHConfig to NodeGroupSSH
Browse files Browse the repository at this point in the history
  • Loading branch information
martina-if committed Apr 8, 2019
1 parent 92ce14d commit 5a7df58
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion pkg/apis/eksctl.io/v1alpha4/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func SetNodeGroupDefaults(_ int, ng *NodeGroup) error {
}

if ng.SSH == nil {
ng.SSH = &SSHConfig{
ng.SSH = &NodeGroupSSH{
Allow: NewBoolFalse(),
}
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/eksctl.io/v1alpha4/defaults_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var _ = Describe("Default settings", func() {

It("Providing an SSH key enables SSH", func() {
testNodeGroup := NodeGroup{
SSH: &SSHConfig{
SSH: &NodeGroupSSH{
Allow: NewBoolFalse(),
PublicKeyPath: &testKeyPath,
},
Expand All @@ -27,7 +27,7 @@ var _ = Describe("Default settings", func() {

It("Enabling SSH without a key uses default key", func() {
testNodeGroup := NodeGroup{
SSH: &SSHConfig{
SSH: &NodeGroupSSH{
Allow: NewBoolTrue(),
},
}
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/eksctl.io/v1alpha4/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func (c *ClusterConfig) NewNodeGroup() *NodeGroup {
ALBIngress: NewBoolFalse(),
},
},
SSH: &SSHConfig{
SSH: &NodeGroupSSH{
Allow: NewBoolFalse(),
PublicKeyPath: &DefaultNodeSSHPublicKeyPath,
},
Expand Down Expand Up @@ -387,7 +387,7 @@ type NodeGroup struct {
// +optional
Taints map[string]string `json:"taints,omitempty"`

SSH *SSHConfig `json:"ssh"`
SSH *NodeGroupSSH `json:"ssh"`

// +optional
IAM *NodeGroupIAM `json:"iam"`
Expand Down Expand Up @@ -451,8 +451,8 @@ type (
ALBIngress *bool `json:"albIngress"`
}

// SSHConfig holds all the ssh access configuration to a NodeGroup
SSHConfig struct {
// NodeGroupSSH holds all the ssh access configuration to a NodeGroup
NodeGroupSSH struct {
// +optional
Allow *bool `json:"allow"`
// +optional
Expand Down
10 changes: 5 additions & 5 deletions pkg/apis/eksctl.io/v1alpha4/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cfn/builder/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ var _ = Describe("CloudFormation template builder API", func() {
ALBIngress: api.NewBoolFalse(),
},
},
SSH: &api.SSHConfig{
SSH: &api.NodeGroupSSH{
Allow: api.NewBoolFalse(),
PublicKeyPath: &defaultSSHKeyPath,
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/utils/kubeconfig/kubeconfig_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ var _ = Describe("Kubeconfig", func() {
InstanceType: "m5.large",
AvailabilityZones: []string{"us-west-2b", "us-west-2a", "us-west-2c"},
PrivateNetworking: false,
SSH: &eksctlapi.SSHConfig{
SSH: &eksctlapi.NodeGroupSSH{
Allow: eksctlapi.NewBoolFalse(),
PublicKeyPath: &exampleSSHKeyPath,
PublicKey: []uint8(nil),
Expand Down

0 comments on commit 5a7df58

Please sign in to comment.