updated master data + bugs related to master data

[nipunarora-eGov]

Summary by CodeRabbit

• New Features

  • Updated configuration for CAMPAIGN_DETAILS, disabling the popup functionality.
  • Introduced new terminology for components, changing "HCM" to "MP" (Microplan) in various labels.

• Bug Fixes

  • Corrected property name in the MDMS data fetching logic for microplan naming.

• Refactor

  • Enhanced naming consistency in the formValidator function.

• Documentation

  • Updated comments and documentation to reflect changes in configuration and naming conventions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to several JavaScript files related to the Microplan configuration and components. Key alterations include the deactivation of the popup feature in the MicroplanConfig function, updates to string constants in the SetupMicroplan component to reflect a terminology shift from "HCM" to "MP", and corrections in property naming conventions in the index.js file. Additionally, a variable renaming in the utilities.js file enhances naming consistency without altering the underlying logic.

Changes

File	Change Summary
.../SetupMicroplanConfig.js	Commented out the showPopupOnSubmission section for CAMPAIGN_DETAILS in the MicroplanConfig function.
.../SetupMicroplan.js	Renamed string constants from "HCM" to "MP" in the SetupMicroplan component, updated filtering logic, and added useEffect hooks for state synchronization.
.../employee/index.js	Corrected property name from MicroplanNamingRegx to MicroplanNamingRegex in the MDMS data fetching logic.
.../utilities.js	Renamed variable microplanNamingRegxString to microplanNamingRegexString in the formValidator function.

Possibly related PRs

• Assumptions #1457: Introduces the AssumptionsForm component, related to the modifications in the MicroplanConfig function.
• Mp assumptions #1477: Updates validation logic for the AssumptionsForm, enhancing handling of assumptions in the microplan configuration.
• Microplan upload #1489: Adds the BulkUpload component, relevant for managing data uploads within the microplan configuration.

Suggested reviewers

• jagankumar-egov

Poem

🐇 In the meadow where changes bloom,
Microplan's features find new room.
With popups silenced, steps now clear,
MP leads the way, bringing cheer!
Regex corrected, names align,
A hop, a skip, all works fine! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/SetupMicroplanConfig.js (1)

Line range hint 7-7: Address TODO comments and consider refactoring similar configurations.

There are several TODO comments in the code that should be addressed:

1. Line 7: "TODO: Do no update this object key:1"
2. Line 35: "TODO: Do no update this object key:2"
3. Line 68: "TODO: Do no update this object key:3"

These comments suggest that certain object keys should not be updated. Consider the following:

1. Clarify the reason for not updating these keys in the comments.
2. If these keys are critical and should never be changed, consider using a constant or enum to define them.

Additionally, the configuration for different steps follows a similar pattern. To improve maintainability and reduce code duplication, consider refactoring the configuration into a more generic structure. For example:

const stepConfigs = [
  {
    stepCount: "1",
    key: "1",
    name: "CAMPAIGN_DETAILS",
    component: "CampaignDetails",
    // ... other specific properties
  },
  // ... other step configurations
];

const generateStepConfig = (config) => ({
  stepCount: config.stepCount,
  key: config.key,
  name: config.name,
  body: [
    {
      isMandatory: false,
      key: config.key.toLowerCase(),
      type: "component",
      skipAPICall: false,
      component: config.component,
      // ... other common properties
      customProps: {
        module: "HCM",
        sessionData: totalFormData,
        isSubmitting: isSubmitting,
        // ... other specific properties
      },
    },
  ],
});

export const MicroplanConfig = (totalFormData, dataParams, isSubmitting, summaryErrors, hierarchyData) => {
  return [
    {
      form: stepConfigs.map(generateStepConfig),
    },
  ];
};

This refactoring would make the code more maintainable and easier to update in the future.

Also applies to: 35-35, 68-68

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Line range hint 1-368: Consider refactoring for improved maintainability

While the specific changes in this file are correct and consistent, I have a few suggestions to improve the overall code quality:

1. The component is quite large and complex. Consider breaking it down into smaller, more manageable sub-components.
2. There are several commented-out code blocks (e.g., lines 269-274 and 330-368). If these are no longer needed, consider removing them to improve code cleanliness.
3. The handleUpdates function (lines 127-136) could benefit from more detailed error handling and logging.
4. Consider using custom hooks to encapsulate some of the complex logic, such as form submission and API interactions.

These suggestions aim to improve the overall maintainability and readability of the code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between b82b6fc and e707c8c.

📒 Files selected for processing (4)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/SetupMicroplanConfig.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/SetupMicroplanConfig.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/configs/SetupMicroplanConfig.js (1)

Line range hint 1-291: Overall review summary

The changes made to this file appear to be intentional and align with the PR objectives. The main modification involves removing the popup functionality for the campaign details step. Here's a summary of the review:

1. The showPopupOnSubmission property has been commented out, which needs verification.
2. TODO comments should be addressed or clarified.
3. Consider refactoring the configuration structure for better maintainability.

These changes and suggestions aim to improve the code quality and maintainability of the MicroplanConfig function. Please review the previous comments for detailed explanations and suggestions.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

262-262: LGTM: Consistent terminology updates

The changes from "HCM_BACK" to "MP_BACK" and "HCM_NEXT" to "MP_NEXT" are consistent with the terminology shift and the previous update in the Stepper component. These changes improve the overall consistency of the user interface.

Also applies to: 268-268