Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added restricted selection in boundary and updated boundary draft red… #1499

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Bhavya-egov
Copy link
Contributor

@Bhavya-egov Bhavya-egov commented Oct 10, 2024

…irection

Summary by CodeRabbit

  • New Features

    • Enhanced popup functionality with explicit close actions and navigation buttons in the CampaignSelection component.
    • Introduced a restrictSelection feature to manage user interactions based on boundary selection.
  • Bug Fixes

    • Improved navigation handling for campaign drafts based on the presence of a parent ID.
  • Refactor

    • Streamlined component logic and state management across multiple components for better user experience.

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes in this pull request primarily enhance the functionality of several components related to campaign management. Key modifications include the introduction of new state variables and props, particularly around managing popup visibility and selection restrictions. The CampaignSelection component now includes an onClose prop for closing popups, while the SelectingBoundariesDuplicate and SelectingBoundaryComponent components have improved state management and logic for handling user interactions. The MyCampaign component has refined navigation logic based on the presence of a parentId.

Changes

File Change Summary
.../CampaignType.js Added onClose prop to PopUp, updated footerChildren with navigation and submit buttons.
.../SelectingBoundariesDuplicate.js Changed initial state of updatedSelected to null, added restrictSelection, refined logic for boundary selection and popup visibility.
.../SelectingBoundaryComponent.js Introduced restrictSelection prop, updated selection handling logic to include popup feedback.
.../MyCampaign.js Updated onClickRow logic for "CAMPAIGN_DRAFTS" to conditionally navigate based on parentId.

Possibly related PRs

  • Vertical stepper implemenetation #1441: The changes in the Vertical stepper implementation PR involve modifications to the Module.js file, which may relate to the overall structure and functionality of components, including the CampaignSelection component in the main PR.
  • Boundary screen #1451: The Boundary screen PR introduces a new CampaignBoundary component, which may interact with the CampaignSelection component's logic regarding campaign boundaries.
  • Assumptions #1457: The Assumptions PR includes changes to the Hypothesis.js component, which may share state management or user interaction patterns with the CampaignSelection component.
  • HCMPRE-700, HCMPRE-701 and HCMPRE-741 #1471: The changes in the HCMPRE-700, HCMPRE-701 and HCMPRE-741 PR involve updates to the index.html file, which could indirectly affect the rendering of the CampaignSelection component through CSS updates.
  • Mp assumptions #1477: The Mp assumptions PR includes modifications to the Hypothesis.js component and related styles, which may impact the user interface and interaction of the CampaignSelection component.
  • fixed summary and campaign creation #1479: The fixed summary and campaign creation PR modifies the CampaignSummary.js and DeliveryDetailsSummary.js components, which may relate to the overall campaign management functionality that includes the CampaignSelection component.
  • updated summary redirection #1488: The updated summary redirection PR updates the BoundarySummary and CampaignSummary components, which may share logic or state with the CampaignSelection component.
  • updated master data + bugs related to master data #1497: The updated master data + bugs related to master data PR modifies the SetupMicroplanConfig.js and related components, which may influence the configuration and behavior of the CampaignSelection component.

Suggested reviewers

  • nipunarora-eGov

🐇 In the fields where campaigns bloom,
A popup now closes, dispelling the gloom.
With boundaries set and selections refined,
Our paths are clearer, our goals aligned.
So hop along, let’s make it right,
With buttons to guide us, we’ll reach new heights! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagankumar-egov jagankumar-egov merged commit 8869434 into console Oct 10, 2024
2 checks passed
@jagankumar-egov jagankumar-egov deleted the popup branch October 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants