Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE] Introduce OracleDatabase VMCluster Resource & Data and DBServer Data #2

Open
wants to merge 130 commits into
base: introduce-exa-data-and-resource
Choose a base branch
from

Conversation

eelhomsi
Copy link
Owner

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PRE-REVIEW - PLEASE DO NOT MERGE

Introduce OracleDatabase VMCluster Resource & Data and DBServer Data
Most relevant changes in:
internal/services/oracledatabase/

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

VMCluster Resource tests (ran one by one due to tenancy resourcing constraints):
Screenshot 2024-08-11 at 12 52 20
Screenshot 2024-08-11 at 13 22 34
Screenshot 2024-08-11 at 13 53 18
Screenshot 2024-08-11 at 14 22 39

VM Cluster Data source:
Screenshot 2024-08-12 at 15 51 40

DB Server Data source:
Screenshot 2024-08-12 at 16 18 10

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • FEATURES - Introduced new CloudVmClusterResource, CloudVmClusterDataSource, and DBServersDataSource`.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@eelhomsi eelhomsi changed the title Introduce OracleDatabase VMCluster Resource & Data and DBServer Data [DONOTMERGE] Introduce OracleDatabase VMCluster Resource & Data and DBServer Data Aug 12, 2024
eelhomsi and others added 27 commits August 23, 2024 19:06
…d-data-source' into introduce-vm-cluster-resource-and-data-source
…uce-vm-cluster-resource-and-data-source

# Conflicts:
#	internal/services/oracledatabase/exadata_infrastructure_data_source.go
#	internal/services/oracledatabase/exadata_infrastructure_data_source_test.go
#	internal/services/oracledatabase/exadata_infrastructure_resource.go
#	internal/services/oracledatabase/exadata_infrastructure_resource_test.go
#	website/docs/d/oracledatabase_exadata_infrastructure.html.markdown
#	website/docs/r/oracledatabase_exadata_infrastructure.html.markdown
…terval_in_hours` to nil when elastic pool is hyperscale (hashicorp#27505)

* set intervalhours to nil if HS elastic pool is used

* linting

* fix typo

* remove extra nil check

* fix nil check
new resource stack hci virtual hard disk
…uiresImport` (hashicorp#27521)

* fix TestAccResourceManagementPrivateLinkAssociation_requiresImport recreate

* fix

* fix
neil-yechenwei and others added 30 commits October 16, 2024 20:41
* New Resource: azurerm_dev_center_attached_network

* update registration

* update tc
…untime_azure_ssis`: fix tests (hashicorp#27634)

* `azurerm_data_factory_data_flow`, `azurerm_data_factory_integration_runtime_azure_ssis`: fix tests

* fix tests
…shicorp#27620)

* `azurerm_iothub` - fixing acctests
`azurerm_iothub_certificate` - fixing acctests

* update testing region for iothub

* typo
…perty (hashicorp#27618)

* `azurerm_iotcentral_organization` - remove acctests on `ForceNew` property

* CI
…ashicorp#27598)

* feat: max_inactive_revisions

* fix: unit tests
…corp#27176)

* * Add Exadata Infrastructure files.

* * Add docs for db_server data source.

* * Update.

* * remove exa.

* * Format.

* * Update.

* * Format.

* * Move to bottom.

* * Add validators.

* * Explain disabling of correlationId being provided by AzureRM.

* * Add new lines and move tags to bottom.

* Update internal/services/oracledatabase/cloud_vm_cluster_resource_test.go

Co-authored-by: kt <[email protected]>

* * Add validation for names.

* * Format blocks.

* * Format blocks.

* * Format blocks.

* * Address comments.

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* * Address comments.

* Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go

* Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go

* * Merge.

* * Fix website linter issues.

* * Merge from main.

* * Update test.

* * Remove fields not supported in ODB@A UI.

* * Adjust timeouts.

* * Rearrange guard.

* * Merge.

* * Website linting.

* * Go linting.

* * Go linting.

* * Format.

* * Rename functions.

* * Added additional validators.

* * Added additional validators.

* * Doc constants.

* * Add suppress comments.

* * Oracle Database -> Oracle.

* * Golint.

* * Fix.

* Update website/docs/d/oracle_cloud_vm_cluster.html.markdown

Co-authored-by: kt <[email protected]>

* Update website/docs/d/oracle_cloud_vm_cluster.html.markdown

Co-authored-by: kt <[email protected]>

* * Fix.

* * Remove unneeded function.

* * Add hostname actual.

* * Update docs.

---------

Co-authored-by: kt <[email protected]>
…ucture" (hashicorp#27676)

* manually revert 27177 as it requires rework

* revert documentation for oracle exadata
…icorp#27678)

* * Add Exadata Infrastructure files.

* * Format.

* * Move to bottom.

* * Add validators.

* * Format blocks.

* * Address comments.

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

Co-authored-by: kt <[email protected]>

* * Address comments.

* Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go

* Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go

* * Fix website linter issues.

* * Merge from main.

* * Update test.

* * Remove fields not supported in ODB@A UI.

* * Adjust timeouts.

* * Rearrange guard and update maintenance window.

* * Update.

* * Update.

* * Update docs.

* * Update name.

* * Update spec.

* * Update spec.

* * Update to address PR comments.

* * Update to address PR comments.

* Update internal/services/oracledatabase/exadata_infrastructure_data_source.go

Co-authored-by: stephybun <[email protected]>

* * Update to address PR comments.

* * Update to address PR comments.

* * Update to address PR comments.

* * Update to address PR comments.

* * Update to address PR comments.

* * Update to address PR comments.

* * Fix test.

* minor adjustments and rewrite of the update function to allow updates of all non ForceNew properties using the CreateOrUpdate method

* revert resource name in acceptance test since OCI side can only accept names beginning with OFake

* * Add ForceNew to Schema.

* * Revert to old update behaviour.

* * Remove `HasChangesExcept` logic.

---------

Co-authored-by: kt <[email protected]>
Co-authored-by: stephybun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.