forked from hashicorp/terraform-provider-azurerm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] Introduce OracleDatabase VMCluster Resource & Data and DBServer Data #2
Open
eelhomsi
wants to merge
130
commits into
introduce-exa-data-and-resource
Choose a base branch
from
introduce-vm-cluster-resource-and-data-source
base: introduce-exa-data-and-resource
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DONOTMERGE] Introduce OracleDatabase VMCluster Resource & Data and DBServer Data #2
eelhomsi
wants to merge
130
commits into
introduce-exa-data-and-resource
from
introduce-vm-cluster-resource-and-data-source
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelhomsi
changed the title
Introduce OracleDatabase VMCluster Resource & Data and DBServer Data
[DONOTMERGE] Introduce OracleDatabase VMCluster Resource & Data and DBServer Data
Aug 12, 2024
…t.go Co-authored-by: kt <[email protected]>
…d-data-source' into introduce-vm-cluster-resource-and-data-source
…e-vm-cluster-resource-and-data-source
…uce-vm-cluster-resource-and-data-source # Conflicts: # internal/services/oracledatabase/exadata_infrastructure_data_source.go # internal/services/oracledatabase/exadata_infrastructure_data_source_test.go # internal/services/oracledatabase/exadata_infrastructure_resource.go # internal/services/oracledatabase/exadata_infrastructure_resource_test.go # website/docs/d/oracledatabase_exadata_infrastructure.html.markdown # website/docs/r/oracledatabase_exadata_infrastructure.html.markdown
…terval_in_hours` to nil when elastic pool is hyperscale (hashicorp#27505) * set intervalhours to nil if HS elastic pool is used * linting * fix typo * remove extra nil check * fix nil check
new resource stack hci virtual hard disk
Update for hashicorp#27474
… reading `mysql_flexible_server` resource (hashicorp#27442)
…tinelAlertRuleScheduled_upgrade` (hashicorp#27516)
…uiresImport` (hashicorp#27521) * fix TestAccResourceManagementPrivateLinkAssociation_requiresImport recreate * fix * fix
…erm_container_app (hashicorp#27495)
* New Resource: azurerm_dev_center_attached_network * update registration * update tc
…e-vm-cluster-resource-and-data-source
…ver side automatic workspace migration (hashicorp#27637)
…untime_azure_ssis`: fix tests (hashicorp#27634) * `azurerm_data_factory_data_flow`, `azurerm_data_factory_integration_runtime_azure_ssis`: fix tests * fix tests
…shicorp#27620) * `azurerm_iothub` - fixing acctests `azurerm_iothub_certificate` - fixing acctests * update testing region for iothub * typo
…perty (hashicorp#27618) * `azurerm_iotcentral_organization` - remove acctests on `ForceNew` property * CI
…different subscription as per hashicorp#27589 (hashicorp#27591)
…ashicorp#27598) * feat: max_inactive_revisions * fix: unit tests
…corp#27176) * * Add Exadata Infrastructure files. * * Add docs for db_server data source. * * Update. * * remove exa. * * Format. * * Update. * * Format. * * Move to bottom. * * Add validators. * * Explain disabling of correlationId being provided by AzureRM. * * Add new lines and move tags to bottom. * Update internal/services/oracledatabase/cloud_vm_cluster_resource_test.go Co-authored-by: kt <[email protected]> * * Add validation for names. * * Format blocks. * * Format blocks. * * Format blocks. * * Address comments. * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * * Address comments. * Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go * Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go * * Merge. * * Fix website linter issues. * * Merge from main. * * Update test. * * Remove fields not supported in ODB@A UI. * * Adjust timeouts. * * Rearrange guard. * * Merge. * * Website linting. * * Go linting. * * Go linting. * * Format. * * Rename functions. * * Added additional validators. * * Added additional validators. * * Doc constants. * * Add suppress comments. * * Oracle Database -> Oracle. * * Golint. * * Fix. * Update website/docs/d/oracle_cloud_vm_cluster.html.markdown Co-authored-by: kt <[email protected]> * Update website/docs/d/oracle_cloud_vm_cluster.html.markdown Co-authored-by: kt <[email protected]> * * Fix. * * Remove unneeded function. * * Add hostname actual. * * Update docs. --------- Co-authored-by: kt <[email protected]>
…r" (hashicorp#27675) This reverts commit cb8d847.
…ucture" (hashicorp#27676) * manually revert 27177 as it requires rework * revert documentation for oracle exadata
…icorp#27678) * * Add Exadata Infrastructure files. * * Format. * * Move to bottom. * * Add validators. * * Format blocks. * * Address comments. * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * Update website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Co-authored-by: kt <[email protected]> * * Address comments. * Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go * Update internal/services/oracledatabase/exadata_infrastructure_resource_test.go * * Fix website linter issues. * * Merge from main. * * Update test. * * Remove fields not supported in ODB@A UI. * * Adjust timeouts. * * Rearrange guard and update maintenance window. * * Update. * * Update. * * Update docs. * * Update name. * * Update spec. * * Update spec. * * Update to address PR comments. * * Update to address PR comments. * Update internal/services/oracledatabase/exadata_infrastructure_data_source.go Co-authored-by: stephybun <[email protected]> * * Update to address PR comments. * * Update to address PR comments. * * Update to address PR comments. * * Update to address PR comments. * * Update to address PR comments. * * Update to address PR comments. * * Fix test. * minor adjustments and rewrite of the update function to allow updates of all non ForceNew properties using the CreateOrUpdate method * revert resource name in acceptance test since OCI side can only accept names beginning with OFake * * Add ForceNew to Schema. * * Revert to old update behaviour. * * Remove `HasChangesExcept` logic. --------- Co-authored-by: kt <[email protected]> Co-authored-by: stephybun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PRE-REVIEW - PLEASE DO NOT MERGE
Introduce OracleDatabase VMCluster Resource & Data and DBServer Data
Most relevant changes in:
internal/services/oracledatabase/
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
VMCluster Resource tests (ran one by one due to tenancy resourcing constraints):
VM Cluster Data source:
DB Server Data source:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
CloudVmClusterResource,
CloudVmClusterDataSource, and
DBServersDataSource`.This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.