-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_dev_center_attached_network
#27638
New Resource: azurerm_dev_center_attached_network
#27638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neil-yechenwei ,
Thanks for this PR - I've taken a look through and left one minor comment inline. If we can fix it up, this should be good to go 👍
@ms-zhenhua , thanks for the comments. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neil-yechenwei ,
Thank you for your confirmation. LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🪐
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
This PR is to support Dev Center Attached Network.
API Reference:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2024-02-01/devcenter.json#L1879
Overview:
https://learn.microsoft.com/en-us/azure/dev-box/how-to-manage-dev-center#attach-a-network-connection-to-a-dev-center
https://learn.microsoft.com/en-us/azure/dev-box/how-to-configure-network-connections?tabs=AzureADJoin
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_dev_center_attached_network
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.