new resource and data source: azurerm_oracle_exadata_infrastructure #27177

eelhomsi · 2024-08-23T18:07:57Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Introduce OracleDatabase ExaData Infrastructure Resource & Data
Most relevant changes in:
internal/services/oracledatabase/

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

ExadataInfraDataSource test:

ExadataInfraResource tests:

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

FEATURES - Introduced new ExadataInfraDataSource and ExadataInfraResource

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

internal/services/oracledatabase/exadata_infrastructure_resource.go

website/docs/r/oracledatabase_exadata_infrastructure.html.markdown

katbyte · 2024-09-24T16:35:36Z

internal/services/oracledatabase/registration.go

+// WebsiteCategories returns a list of categories which can be used for the sidebar
+func (r Registration) WebsiteCategories() []string {
+	return []string{
+		"App Service",


this is wrong?

Fixed, thanks!

katbyte · 2024-09-24T16:35:46Z

internal/services/oracledatabase/registration.go

+
+// Name is the name of this Service
+func (r Registration) Name() string {
+	return "App Service"


katbyte · 2024-09-24T16:39:56Z

internal/services/oracledatabase/exadata_infrastructure_resource.go

+			var output ExadataInfraResourceModel
+
+			output.CustomerContacts = FlattenCustomerContacts(result.Model.Properties.CustomerContacts)
+			output.Name = pointer.ToString(result.Model.Name)
+			output.Location = result.Model.Location
+			output.Zones = result.Model.Zones
+			output.ResourceGroupName = id.ResourceGroupName
+			output.Tags = utils.FlattenPtrMapStringString(result.Model.Tags)
+			prop := result.Model.Properties
+			output.ComputeCount = pointer.From(prop.ComputeCount)
+			output.DisplayName = prop.DisplayName
+			output.StorageCount = pointer.From(prop.StorageCount)
+			output.Shape = prop.Shape
+			output.MaintenanceWindow = FlattenMaintenanceWindow(prop.MaintenanceWindow)


minor issue but to match other resources we should inline this/do an assingment

output := ExadataInfraResourceModel { CustomerContacts: FlattenCustomerContacts(result.Model.Properties.CustomerContacts) Name: pointer.ToString(result.Model.Name) ...

and such vs going outout.x

Understood, I've updated the code.

katbyte · 2024-09-24T16:40:52Z

internal/services/oracledatabase/exadata_infrastructure_resource.go

+						Optional: true,
+						Computed: true,
+						Elem: &pluginsdk.Schema{
+							Type: pluginsdk.TypeInt,


this should be validated between 1-5?

Internally we want 1-4, I've updated to validate that, thank you.

katbyte · 2024-09-24T16:41:04Z

internal/services/oracledatabase/exadata_infrastructure_resource.go

+					"preference": {
+						Type:     pluginsdk.TypeString,
+						Optional: true,
+						Computed: true,


this should be validated?

katbyte · 2024-09-24T16:41:30Z

internal/services/oracledatabase/exadata_infrastructure_resource.go

+						Optional: true,
+						Computed: true,
+						Elem: &pluginsdk.Schema{
+							Type: pluginsdk.TypeString,


and here?

please validate all properties

katbyte · 2024-09-24T16:42:27Z

internal/services/oracledatabase/exadata_infrastructure_data_source.go

+				output.Name = id.CloudExadataInfrastructureName
+				output.ResourceGroupName = id.ResourceGroupName
+				output.Type = pointer.From(model.Type)
+				output.Tags = utils.FlattenPtrMapStringString(model.Tags)
+				output.Location = model.Location
+				output.Zones = model.Zones


why are these seperate and not included above?

I've moved them up with the test.

…down Co-authored-by: kt <[email protected]>

… into introduce-exa-data-and-resource

…ce_test.go

eelhomsi · 2024-10-04T00:11:23Z

I think this now looks good provided CI passes, please show confirmation of passing tests and we can get this merged

I've added testing evidence here:

…e-exa-data-and-resource

katbyte · 2024-10-10T05:38:17Z

@eelhomsi please run make terrafmt to fix ci

…e-exa-data-and-resource

eelhomsi · 2024-10-10T07:35:55Z

@eelhomsi please run make terrafmt to fix ci

Done

…e-exa-data-and-resource

eelhomsi · 2024-10-11T19:11:28Z

Latest tests here:

jackofallops · 2024-10-17T08:44:33Z

Hi @eelhomsi - Apologies again, but we need to revert this one also. Can you please re-open the PR from your branch and we'll work with you to get this in asap.

Thanks

eelhomsi · 2024-10-17T09:06:28Z

Hi @eelhomsi - Apologies again, but we need to revert this one also. Can you please re-open the PR from your branch and we'll work with you to get this in asap.

Thanks

No problem @jackofallops PR recreated here:
#27678

github-actions · 2024-11-17T02:22:07Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

eelhomsi added 2 commits August 9, 2024 21:44

* Add Exadata Infrastructure files.

90eb21b

Merge branch 'main' into introduce-exa-data-and-resource

9482eba

github-actions bot added documentation dependencies size/XL waiting-response labels Aug 23, 2024

* Format.

d26aada

github-actions bot added waiting-response and removed waiting-response labels Sep 3, 2024

katbyte requested changes Sep 5, 2024

View reviewed changes

website/docs/r/oracledatabase_exadata_infrastructure.html.markdown Show resolved Hide resolved

internal/services/oracledatabase/exadata_infrastructure_resource.go Show resolved Hide resolved

internal/services/oracledatabase/exadata_infrastructure_resource.go Outdated Show resolved Hide resolved

* Move to bottom.

16a5e92

github-actions bot removed the waiting-response label Sep 9, 2024

eelhomsi added 2 commits September 9, 2024 09:30

* Add validators.

61e90b7

* Format blocks.

6f35ff7

github-actions bot added the waiting-response label Sep 18, 2024

eelhomsi changed the title ~~[DONOTMERGE] Introduce OracleDatabase ExaData Infrastructure Resource & Data~~ Introduce OracleDatabase ExaData Infrastructure Resource & Data Sep 24, 2024

* Address comments.

19bc88c

github-actions bot removed the waiting-response label Sep 24, 2024

katbyte requested changes Sep 24, 2024

View reviewed changes

github-actions bot added the waiting-response label Sep 24, 2024

eelhomsi and others added 2 commits September 25, 2024 18:54

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

b3e4f33

…down Co-authored-by: kt <[email protected]>

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

76a1f16

…down Co-authored-by: kt <[email protected]>

github-actions bot removed the waiting-response label Sep 25, 2024

eelhomsi and others added 3 commits September 25, 2024 18:54

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

4652730

…down Co-authored-by: kt <[email protected]>

* Address comments.

4ab3c70

Merge remote-tracking branch 'origin/introduce-exa-data-and-resource'…

659816a

… into introduce-exa-data-and-resource

github-actions bot added the waiting-response label Sep 27, 2024

Update internal/services/oracledatabase/exadata_infrastructure_resour…

2253a16

…ce_test.go

github-actions bot removed the waiting-response label Sep 27, 2024

Update internal/services/oracledatabase/exadata_infrastructure_resour…

936cd8c

…ce_test.go

eelhomsi added 6 commits October 4, 2024 13:15

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

4745284

…e-exa-data-and-resource

* Adjust timeouts.

a148c3f

* Rearrange guard and update maintenance window.

40aa9ac

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

2449ce3

…e-exa-data-and-resource

* Update.

6101d90

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

0868f6b

…e-exa-data-and-resource

github-actions bot added the waiting-response label Oct 10, 2024

eelhomsi added 2 commits October 10, 2024 08:33

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

809c7cc

…e-exa-data-and-resource

* Update.

2db6d11

github-actions bot removed the waiting-response label Oct 10, 2024

eelhomsi added 6 commits October 11, 2024 13:27

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

50a2a9f

…e-exa-data-and-resource

* Update docs.

3ccf7ba

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

3f0ac5b

…e-exa-data-and-resource

* Update name.

dbc8fd4

* Update spec.

8da9bc6

* Update spec.

4634c98

katbyte changed the title ~~Introduce OracleDatabase ExaData Infrastructure Resource & Data~~ new resource and data source: azurerm_oracle_exadata_infrastructure Oct 11, 2024

katbyte merged commit 5a3a324 into hashicorp:main Oct 11, 2024
33 checks passed

github-actions bot added this to the v4.6.0 milestone Oct 11, 2024

katbyte added a commit that referenced this pull request Oct 11, 2024

Update CHANGELOG.md #27177

1e3ae7c

stephybun mentioned this pull request Oct 17, 2024

Revert "new resource and data source: azurerm_oracle_exadata_infrastructure" #27676

Merged

jackofallops added a commit that referenced this pull request Oct 17, 2024

Update CHANGELOG.md reverting #27177

57cd1c8

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource and data source: azurerm_oracle_exadata_infrastructure #27177

new resource and data source: azurerm_oracle_exadata_infrastructure #27177

eelhomsi commented Aug 23, 2024 •

edited

Loading

katbyte Sep 24, 2024

eelhomsi Sep 26, 2024

katbyte Sep 24, 2024

katbyte Sep 24, 2024

eelhomsi Sep 26, 2024

katbyte Sep 24, 2024

eelhomsi Sep 26, 2024

katbyte Sep 24, 2024

katbyte Sep 24, 2024

eelhomsi Sep 26, 2024

katbyte Sep 24, 2024

eelhomsi Sep 26, 2024

eelhomsi commented Oct 4, 2024

katbyte commented Oct 10, 2024

eelhomsi commented Oct 10, 2024

eelhomsi commented Oct 11, 2024

jackofallops commented Oct 17, 2024

eelhomsi commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Nov 17, 2024

new resource and data source: azurerm_oracle_exadata_infrastructure #27177

new resource and data source: azurerm_oracle_exadata_infrastructure #27177

Conversation

eelhomsi commented Aug 23, 2024 • edited Loading

Community Note

Description

PR Checklist

Testing

Change Log

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eelhomsi commented Oct 4, 2024

katbyte commented Oct 10, 2024

eelhomsi commented Oct 10, 2024

eelhomsi commented Oct 11, 2024

jackofallops commented Oct 17, 2024

eelhomsi commented Oct 17, 2024 • edited Loading

github-actions bot commented Nov 17, 2024

eelhomsi commented Aug 23, 2024 •

edited

Loading

eelhomsi commented Oct 17, 2024 •

edited

Loading