Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly skip NM tests if nm is not available #434

Closed
gijzelaerr opened this issue Dec 17, 2021 · 3 comments
Closed

Properly skip NM tests if nm is not available #434

gijzelaerr opened this issue Dec 17, 2021 · 3 comments
Assignees
@jwijenbergh
Milestone
4.2

Comments

@gijzelaerr
Copy link
Collaborator

gijzelaerr commented Dec 17, 2021 •
edited
Loading

This fails during test run while building the packages. There is no network traffic allowed during package building, so the build fails (on copr).
@gijzelaerr gijzelaerr mentioned this issue Dec 17, 2021
Closed
@gijzelaerr gijzelaerr added this to the 2.3 milestone Dec 17, 2021
@gijzelaerr
Copy link
Collaborator Author

This is still an issue and the test is currently skipped.

@gijzelaerr gijzelaerr modified the milestones: 2.3, 2.4 Apr 22, 2022
@jwijenbergh jwijenbergh mentioned this issue Oct 31, 2022
Merged
5 tasks
@jwijenbergh jwijenbergh changed the title Mock all network calls in tests/test_flow.py::FlowTests::test_first_start Properly skip NM tests if nm is not available Mar 6, 2023
@jwijenbergh
Copy link
Collaborator

I have renamed this issue to tackle a related issue

@jwijenbergh jwijenbergh modified the milestones: 4.0, 4.1 Mar 6, 2023
@jwijenbergh jwijenbergh modified the milestones: 4.1, 4.2 Apr 19, 2023
jwijenbergh added a commit that referenced this issue Oct 20, 2023
@jwijenbergh
NM: Fixes for #434
5ba4505
@jwijenbergh
Copy link
Collaborator

fixed in master

@jwijenbergh jwijenbergh mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwijenbergh jwijenbergh

Labels
None yet
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@gijzelaerr @jwijenbergh