fix obvious errors when NetworkManager is missing #547

fogti · 2023-09-03T11:42:52Z

this fixes all the "startup time" errors encountered when trying to use this without NetworkManager

it doesn't really work yet tho, e.g.:

$ venv/bin/eduvpn-cli interactive
Network Manager not available
keyring not available due to import not available
Traceback (most recent call last):
  File "~/devel/python-eduvpn-client/venv/lib/python3.11/site-packages/eduvpn/nm.py", line 786, in <lambda>
    GLib.idle_add(lambda: action(callback=quit_loop))
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/devel/python-eduvpn-client/venv/lib/python3.11/site-packages/eduvpn/cli.py", line 485, in update_state_callback
    state = self.nm_manager.connection_state
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/devel/python-eduvpn-client/venv/lib/python3.11/site-packages/eduvpn/nm.py", line 181, in connection_state
    for connection in self.client.get_active_connections()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get_active_connections'

jwijenbergh · 2023-09-04T07:43:20Z

Thanks for the PR. Are you trying to use the client without NetworkManager or just looking to improve the error handling when it is not available?

Currently client cannot work without it but it does make sense to add extra error checking when NetworkManager is not available.

Note that for the error you're getting right now you might need to check if NetworkManager is available by adding an if statement here:

https://github.com/eduvpn/python-eduvpn-client/blob/master/eduvpn/cli.py#L655

Would you like to add that check?

fogti · 2023-09-04T20:37:32Z

basically, it would be nice to be able to generate plaintext configs without NM. (so that's the end goal, but this fixes just the stuff that directly crashes)

fogti · 2023-09-04T21:04:41Z

eduvpn/nm.py

@@ -19,18 +19,16 @@
 from eduvpn.utils import run_in_glib_thread
 from eduvpn.variants import ApplicationVariant

-gi.require_version("NM", "1.0")  # noqa: E402
+from gi.repository import GLib  # type: ignore


probably something like gi.require_version("GLib", "2.0") or such should also be inserted here...

Whatever works is fine by me :)

jwijenbergh · 2023-09-05T08:02:50Z

basically, it would be nice to be able to generate plaintext configs without NM. (so that's the end goal, but this fixes just the stuff that directly crashes)

I agree that this is useful especially for the CLI, maybe not so much for the GUI?

jwijenbergh · 2023-09-05T08:16:45Z

Also if you're right now looking to have a very basic eduVPN cli, you may also use https://github.com/eduvpn/eduvpn-common/blob/main/cmd/cli/main.go

jwijenbergh · 2023-10-20T13:04:12Z

I made some tiny changes to fix #434, can you rebase if you're still working on this?

nezos · 2023-12-12T09:58:37Z

@jwijenbergh if I understand correctly the changes will only skip the tests for NM? But how will it be possible with eduvpn-cli to connect without NM? Could you provide a step by step procedure?

Thanks

PS: I installed 4.2 but with existing configurations it complains about network manager - not sure if the present fix was merged in another way

 File "/usr/lib/python3.12/site-packages/eduvpn/nm.py", line 804, in add_connection_callback
    new_con = client.add_connection_finish(result)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gi.repository.GLib.GError: nm-client-error-quark: NetworkManager is not running (1)

jwijenbergh · 2023-12-12T12:30:46Z

@jwijenbergh if I understand correctly the changes will only skip the tests for NM? But how will it be possible with eduvpn-cli to connect without NM? Could you provide a step by step procedure?

Thanks

PS: I installed 4.2 but with existing configurations it complains about network manager - not sure if the present fix was merged in another way
 File "/usr/lib/python3.12/site-packages/eduvpn/nm.py", line 804, in add_connection_callback
    new_con = client.add_connection_finish(result)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gi.repository.GLib.GError: nm-client-error-quark: NetworkManager is not running (1)

Hi, I think the goal is that it will save the WireGuard/OpenVPN configuration somewhere so that you can manually configure the VPN using wg-quick or the OpenVPN cli. This pr would then make the tool at least run without have the NM tools installed (so that the next step is saving the VPN config somewhere)

fogti · 2024-03-08T11:29:15Z

@jwijenbergh

Also if you're right now looking to have a very basic eduVPN cli, you may also use

How does one use that?

jwijenbergh · 2024-03-20T15:02:27Z

@jwijenbergh

Also if you're right now looking to have a very basic eduVPN cli, you may also use

How does one use that?

Sorry didn't see this. See the help:

Usage of ./eduvpn-common-cli:
  -get-custom string
    	The url of a custom server to connect to
  -get-institute string
    	The url of an institute to connect to
  -get-secure string
    	Gets secure internet servers

For the URLs, see https://disco.eduvpn.org/v2/

Note that it outputs the OpenVPN/WireGuard config to the terminal output.

fogti · 2024-03-20T17:30:38Z

hmmm it's weird...

Opening browser...
2024/03/20 18:27:15 - Go - DEBUG - Getting access token
2024/03/20 18:27:15 - Go - DEBUG - Access token is not expired, returning
2024/03/20 18:27:15 - Go - DEBUG - Getting access token
2024/03/20 18:27:15 - Go - DEBUG - Access token is not expired, returning
panic: runtime/cgo: misuse of an invalid Handle

goroutine 1 [running]:
runtime/cgo.Handle.Value(...)
	/usr/lib/go/src/runtime/cgo/handle.go:124
github.com/eduvpn/eduvpn-common/types/cookie.NewWithContext({0x949398, 0xc000364090})
	/home/fogti/devel/_read-only/eduvpn-common/types/cookie/cookie.go:35 +0x13a
github.com/eduvpn/eduvpn-common/client.(*Client).InvalidProfile(0xc00009eea0, {0x949398?, 0xc000364090?}, 0xc05960?)
	/home/fogti/devel/_read-only/eduvpn-common/client/client.go:73 +0x31
github.com/eduvpn/eduvpn-common/internal/server.(*Servers).ConnectWithCallbacks(0xc00009eeb0, {0x949398, 0xc000364090}, 0xc000364060, 0x0?)
	/home/fogti/devel/_read-only/eduvpn-common/internal/server/servers.go:118 +0x16a
github.com/eduvpn/eduvpn-common/client.(*Client).GetConfig(0xc00009eea0, 0xc000115650, {0x7fff9cd9a0c0?, 0x1b?}, 0x1, 0x0?, 0x0)
	/home/fogti/devel/_read-only/eduvpn-common/client/client.go:434 +0xb05
main.getConfig(0xc00009eea0?, {0x7fff9cd9a0c0?, 0xc0000142b0?}, 0xa?)
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:153 +0x138
main.printConfig({0x7fff9cd9a0c0, 0x1b}, 0xa?)
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:187 +0x24a
main.main()
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:209 +0x145

jwijenbergh · 2024-03-20T17:42:12Z

hmmm it's weird...

Opening browser...
2024/03/20 18:27:15 - Go - DEBUG - Getting access token
2024/03/20 18:27:15 - Go - DEBUG - Access token is not expired, returning
2024/03/20 18:27:15 - Go - DEBUG - Getting access token
2024/03/20 18:27:15 - Go - DEBUG - Access token is not expired, returning
panic: runtime/cgo: misuse of an invalid Handle

goroutine 1 [running]:
runtime/cgo.Handle.Value(...)
	/usr/lib/go/src/runtime/cgo/handle.go:124
github.com/eduvpn/eduvpn-common/types/cookie.NewWithContext({0x949398, 0xc000364090})
	/home/fogti/devel/_read-only/eduvpn-common/types/cookie/cookie.go:35 +0x13a
github.com/eduvpn/eduvpn-common/client.(*Client).InvalidProfile(0xc00009eea0, {0x949398?, 0xc000364090?}, 0xc05960?)
	/home/fogti/devel/_read-only/eduvpn-common/client/client.go:73 +0x31
github.com/eduvpn/eduvpn-common/internal/server.(*Servers).ConnectWithCallbacks(0xc00009eeb0, {0x949398, 0xc000364090}, 0xc000364060, 0x0?)
	/home/fogti/devel/_read-only/eduvpn-common/internal/server/servers.go:118 +0x16a
github.com/eduvpn/eduvpn-common/client.(*Client).GetConfig(0xc00009eea0, 0xc000115650, {0x7fff9cd9a0c0?, 0x1b?}, 0x1, 0x0?, 0x0)
	/home/fogti/devel/_read-only/eduvpn-common/client/client.go:434 +0xb05
main.getConfig(0xc00009eea0?, {0x7fff9cd9a0c0?, 0xc0000142b0?}, 0xa?)
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:153 +0x138
main.printConfig({0x7fff9cd9a0c0, 0x1b}, 0xa?)
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:187 +0x24a
main.main()
	/home/fogti/devel/_read-only/eduvpn-common/cmd/cli/main.go:209 +0x145

Could you try the latest stable release? git checkout 1.2.0

fogti · 2024-03-20T19:35:50Z

stable release works.

jwijenbergh · 2024-03-20T20:33:05Z

stable release works.

Thanks I am aware of the dev issue. Will sort that before the new stable release

jwijenbergh · 2024-07-17T11:39:00Z

Hi, do you still need this @fogti. I think I want to implement non-networkmanager support by adding a flag to dump the config file instead.

fogti · 2024-07-17T11:51:09Z

as long as that part works without having network manager installed, I'm fine with it.

jwijenbergh · 2024-07-17T12:31:21Z

as long as that part works without having network manager installed, I'm fine with it.

Thanks, is it okay if I close this and work on this later?

fix obvious errors when NetworkManager is missing

1948181

fogti force-pushed the minfix branch from f2f5d28 to 1948181 Compare September 4, 2023 20:35

fogti commented Sep 4, 2023

View reviewed changes

Merge branch 'master' into minfix

836f771

jwijenbergh mentioned this pull request Nov 21, 2023

Use client without network manager #562

Closed

Merge branch 'master' into minfix

ee9b544

fogti closed this Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix obvious errors when NetworkManager is missing #547

fix obvious errors when NetworkManager is missing #547

fogti commented Sep 3, 2023

jwijenbergh commented Sep 4, 2023 •

edited

Loading

fogti commented Sep 4, 2023

fogti Sep 4, 2023

jwijenbergh Sep 5, 2023

jwijenbergh commented Sep 5, 2023

jwijenbergh commented Sep 5, 2023

jwijenbergh commented Oct 20, 2023 •

edited

Loading

nezos commented Dec 12, 2023

jwijenbergh commented Dec 12, 2023

fogti commented Mar 8, 2024

jwijenbergh commented Mar 20, 2024

fogti commented Mar 20, 2024

jwijenbergh commented Mar 20, 2024

fogti commented Mar 20, 2024

jwijenbergh commented Mar 20, 2024 •

edited

Loading

jwijenbergh commented Jul 17, 2024

fogti commented Jul 17, 2024

jwijenbergh commented Jul 17, 2024

fix obvious errors when NetworkManager is missing #547

fix obvious errors when NetworkManager is missing #547

Conversation

fogti commented Sep 3, 2023

jwijenbergh commented Sep 4, 2023 • edited Loading

fogti commented Sep 4, 2023

fogti Sep 4, 2023

Choose a reason for hiding this comment

jwijenbergh Sep 5, 2023

Choose a reason for hiding this comment

jwijenbergh commented Sep 5, 2023

jwijenbergh commented Sep 5, 2023

jwijenbergh commented Oct 20, 2023 • edited Loading

nezos commented Dec 12, 2023

jwijenbergh commented Dec 12, 2023

fogti commented Mar 8, 2024

jwijenbergh commented Mar 20, 2024

fogti commented Mar 20, 2024

jwijenbergh commented Mar 20, 2024

fogti commented Mar 20, 2024

jwijenbergh commented Mar 20, 2024 • edited Loading

jwijenbergh commented Jul 17, 2024

fogti commented Jul 17, 2024

jwijenbergh commented Jul 17, 2024

jwijenbergh commented Sep 4, 2023 •

edited

Loading

jwijenbergh commented Oct 20, 2023 •

edited

Loading

jwijenbergh commented Mar 20, 2024 •

edited

Loading