Refactor the app by using the Go library #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of a flicker where it shows all the results briefly
We create a new one every time because Gtk has some weird behaviour regarding the width of the combo box. When we add items that are large, the combobox resizes to fit the content. However, when we add items again that are all smaller (e.g. for a new server), the combo box does not shrink back. The only proper way seems to be to recreate the combobox every time
instead log debug
This is the same as the Go library currently
NetworkManager doesn't expose it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the whole app using the eduvpn-common Go library.
Motivation
There is lots of duplicated code between eduVPN clients, using a common library would allow us to get new features faster and make it easier for the clients. You can read more about this library here https://eduvpn.github.io/eduvpn-common/.
Fixes
#481 - The OAuth library/implementation we use now is built in house and fixes this
#478/#465 - A profile expander is shown now
#467 - The CLI has been rewritten to be more user friendly and work correctly with the V3 API
#453 - Back buttons are shown correctly where they are possible/needed
#434 - Most tests are now in the Go library that sets up a local network
#428 - Proper imeouts are now used
#426 - A renew session button is shown with accordance to the eduVPN specification https://github.com/eduvpn/documentation/blob/v3/API.md#session-expiry
#412 - Prehashed signatures are supported because we use the official minisign go library in the eduvpn-common codebase
#405 - The CLI now works correctly and should be more user friendly, especially if the interactive mode is used
#374 - Let's Connect! now also has a CLI
#351 - No longer a warning should be shown
#336 - Implemented
#335 - Exceptions are now shown in an error revealer similar to other clients
#333 - Implemented
#255 - We now implement it according to the eduVPN specification
#253 - Removing a connection is now possible by right clicking on a server
New features/Improvements that are not mentioned yet
Upgrade notice
This implementation uses a new format for storing the configuration files. You will need to add your servers again
Testing this PR
To easily test this PR, I have set up a Fedora COPR: https://copr.fedorainfracloud.org/coprs/jwijenbergh/eduvpn-common/. A repo with deb files will follow later
Todo
This is a list of things I want to do before I make this a complete release