-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Rework Core Commands via messaging to use new MessageBus Request API #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
cloudxxx8,
FelixTing,
jim-wang-intel,
marcpfuller and
ejlee3
January 25, 2023 23:14
lenny-goodell
force-pushed
the
mb-request
branch
2 times, most recently
from
January 31, 2023 23:56
959a7f2
to
e0edf54
Compare
5 tasks
lenny-goodell
force-pushed
the
mb-request
branch
from
February 6, 2023 21:16
e0edf54
to
129ea7f
Compare
5 tasks
lenny-goodell
added
tech-debt
issue_type denoting refactoring to improve design or removal of temporary workarounds
breaking-change
labels
Feb 6, 2023
lenny-goodell
force-pushed
the
mb-request
branch
from
February 7, 2023 15:50
129ea7f
to
ca41e6d
Compare
…equst API BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration. closes edgexfoundry#4309 fixes #4304 Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell
force-pushed
the
mb-request
branch
from
February 7, 2023 15:53
ca41e6d
to
cf69550
Compare
lenny-goodell
removed
tech-debt
issue_type denoting refactoring to improve design or removal of temporary workarounds
breaking-change
labels
Feb 7, 2023
lenny-goodell
force-pushed
the
mb-request
branch
from
February 7, 2023 15:56
cf69550
to
36f2119
Compare
Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell
force-pushed
the
mb-request
branch
from
February 7, 2023 17:34
36f2119
to
1a94645
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
jim-wang-intel
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcpfuller
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always
edgex/response/<responding-service-name>/<request-id>
.closes #4309
signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)N/A Docs focus on external usage. This PR is just for internal usage.
Testing Instructions
Run non-secure EdgeX stack w/o any device service
Stop Core Command
Build local Device Simple from this PR's branch
Build local App Service Template from this PR's branch
Build Core Command locally from this branch
Run Core Command (
./core-command
)Run Device Simple (
device-simple) twice so it properly finds device, etc. on the 2nd run Run App Template (
./app-new-service`)Verify App template log shows messages like:
Let run for 10 mins and verify no time out errors occur.
New Dependency Instructions (If applicable)