Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rework Core Commands via messaging to use new MessageBus Request API #4310

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 25, 2023

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>.

closes #4309

signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    N/A Docs focus on external usage. This PR is just for internal usage.

Testing Instructions

Run non-secure EdgeX stack w/o any device service
Stop Core Command
Build local Device Simple from this PR's branch
Build local App Service Template from this PR's branch
Build Core Command locally from this branch
Run Core Command (./core-command)
Run Device Simple (device-simple) twice so it properly finds device, etc. on the 2nd run Run App Template (./app-new-service`)
Verify App template log shows messages like:

level=DEBUG ts=2023-02-06T21:32:14.6025413Z app=app-new-service source=sample.go:116 msg="Issuing Command Query for device Simple-Device01 in pip
eline 'default-pipeline'"
level=DEBUG ts=2023-02-06T21:32:14.6066121Z app=app-new-service source=sample.go:126 msg="Device Simple-Device01 has 7 commands to choose from. (
in pipeline 'default-pipeline')"
level=DEBUG ts=2023-02-06T21:32:14.606666Z app=app-new-service source=sample.go:142 msg="Issuing Command Rotation for device Simple-Device01 in i
n pipeline 'default-pipeline'"
level=DEBUG ts=2023-02-06T21:32:14.6123333Z app=app-new-service source=sample.go:150 msg="SendGetCommand successfully received new event from GET
 command Rotation on Simple-Device01 device in pipeline 'default-pipeline'"

Let run for 10 mins and verify no time out errors occur.

New Dependency Instructions (If applicable)

…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309
fixes #4304

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell removed tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds breaking-change labels Feb 7, 2023
@lenny-goodell lenny-goodell removed this from the Minnesota milestone Feb 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 7290d2e into edgexfoundry:main Feb 7, 2023
@lenny-goodell lenny-goodell deleted the mb-request branch February 7, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Core Command via MessageBus to use new MessageBus Request API
3 participants