Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Use latest MessageBus for new Request API #1290

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

lenny-goodell
Copy link
Member

BREAKING CHANGE: Topics for Commands via MessageBus have changed.

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

See edgexfoundry/edgex-go#4310

New Dependency Instructions (If applicable)

jim-wang-intel
jim-wang-intel previously approved these changes Feb 6, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell force-pushed the mb-request branch 2 times, most recently from 205e1ff to b4ff79f Compare February 6, 2023 21:27
@lenny-goodell lenny-goodell changed the title feat: Use latest MessageBus for new Request API feat!: Use latest MessageBus for new Request API Feb 7, 2023
Leonard Goodell added 2 commits February 7, 2023 09:11
BREAKING CHANGE: Topics for Commands via MessageBus have changed.

Signed-off-by: Leonard Goodell <[email protected]>
BREAKING CHANGE: Topics for Commands via MessageBus have changed.

Signed-off-by: Leonard Goodell <[email protected]>
jim-wang-intel
jim-wang-intel previously approved these changes Feb 7, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 3eb0e8b into edgexfoundry:main Feb 7, 2023
@lenny-goodell lenny-goodell deleted the mb-request branch February 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants