Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Core Command via MessageBus to use new MessageBus Request API #4309

Closed
lenny-goodell opened this issue Jan 25, 2023 · 0 comments · Fixed by #4310
Closed

Refactor Core Command via MessageBus to use new MessageBus Request API #4309

lenny-goodell opened this issue Jan 25, 2023 · 0 comments · Fixed by #4310
Assignees
@lenny-goodell
Labels
enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Milestone
Minnesota

Comments

@lenny-goodell
Copy link
Member

🚀 Refactor Request

Relevant Package [REQUIRED]

This feature request is for Core Command

Description [REQUIRED]

MessageBus now has the new Request API with encapsulates the request/response of the MessageBus. Core Commands via MessageBus needs to be refactored to use it.

Describe the solution you'd like

Refactor Core Command via MessageBus to use new MessageBus Request API

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@lenny-goodell lenny-goodell added enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Jan 25, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Jan 25, 2023
@lenny-goodell lenny-goodell self-assigned this Jan 25, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Jan 25, 2023
@lenny-goodell lenny-goodell moved this from New Issues to In Progress in Technical WG Jan 25, 2023
@lenny-goodell lenny-goodell moved this from In Progress to QA/Code Review in Technical WG Jan 25, 2023
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jan 25, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
567145c 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Aslo the internal response topic is aways edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

coses edgexfoundry#4309

signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jan 25, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
1220d94 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Aslo the internal response topic is aways edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

coses edgexfoundry#4309

signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jan 25, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
a657cc1 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell mentioned this issue Jan 25, 2023
Merged
5 tasks
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jan 31, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
959a7f2 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309

Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Jan 31, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
e0edf54 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309

Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Feb 6, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
129ea7f 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309

Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Feb 7, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
3a52f22 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309
fixes #4304

Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Feb 7, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
d9da032 
…equst API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes edgexfoundry#4309
fixes #4304

Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell pushed a commit that referenced this issue Feb 7, 2023
refactor!: Rework Core Commands via messaging to use new MessageBus R…
7290d2e 
…equest API (#4310)

* refactor!: Rework Core Commands via messaging to use new MessageBus Request API

BREAKING CHANGE: Topics configuration for Core Command has changed. Also the internal response topic is always edgex/response/<responding-service-name>/<request-id>. The prefix for this is now part of the standard MessageBus configuration.

closes #4309

Signed-off-by: Leonard Goodell <[email protected]>
@github-project-automation github-project-automation bot moved this from QA/Code Review to Minnesota Done in Technical WG Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
Technical WG
Archived in project
Milestone
Minnesota
1 participant
@lenny-goodell