Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name field escape configurable #4673

Closed
weichou1229 opened this issue Sep 6, 2023 · 2 comments · Fixed by #4674
Closed

Name field escape configurable #4673

weichou1229 opened this issue Sep 6, 2023 · 2 comments · Fixed by #4674
Labels
enhancement New feature or request

Comments

@weichou1229
Copy link
Member

weichou1229 commented Sep 6, 2023 •
edited
Loading

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core services and device service

Description [REQUIRED]

The Url escape function should be configurable.

  1. Add config for all services, default is false,
all-services:
    Service:
        EnableNameFieldEscape: false
  1. Skip the escape function if EnableNameFieldEscape is false

Refer to #4053
@weichou1229 weichou1229 added the enhancement New feature or request label Sep 6, 2023
@cloudxxx8
Copy link
Member

cloudxxx8 commented Sep 6, 2023 •
edited
Loading

rename to EnableNameFieldEscape and add the following comments
// The name field escape could allow the system to use special or Chinese characters in the different name fields, including device, profile, and so on. If the EnableNameFieldEscape is false, some special characters might cause system error.

@weichou1229 weichou1229 changed the title Url escape configurable Name field escape configurable Sep 6, 2023
@jumpingliu jumpingliu moved this from New Issues to In Progress in Technical WG Sep 7, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Sep 7, 2023
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 7, 2023
@weichou1229
feat!: Allow name field escape configurable
f25f8a5 
BREAKING CHANGE: Add config and modify topic build logic to allow name field escape configurable.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
@weichou1229 weichou1229 mentioned this issue Sep 7, 2023
Merged
5 tasks
@weichou1229
Copy link
Member Author

Opened related PRs

This was referenced Sep 8, 2023
Merged
Merged
Merged
@jumpingliu jumpingliu moved this from In Progress to QA/Code Review in Technical WG Sep 8, 2023
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 12, 2023
@weichou1229
feat: Allow name field escape configurable
2e47f21 
Add config and modify topic build logic to allow name field escape configurable.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 14, 2023
@weichou1229
feat: Allow name field escape configurable
4cb232a 
Add config and modify topic build logic to allow name field escape configurable.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 14, 2023
@weichou1229
build: Upgrade dependency libs
df42bd9 
Upgrade go-mod-bootstrap and go-mod-core-contracts.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 14, 2023
@weichou1229
feat: Allow name field escape configurable
6380a38 
Add config and modify topic build logic to allow name field escape configurable.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 14, 2023
@weichou1229
build: Upgrade dependency libs
650e734 
Upgrade go-mod-bootstrap and go-mod-core-contracts.

Close edgexfoundry#4673

Signed-off-by: bruce <[email protected]>
@github-project-automation github-project-automation bot moved this from QA/Code Review to Napa Done in Technical WG Sep 14, 2023
cloudxxx8 pushed a commit that referenced this issue Sep 14, 2023
@weichou1229
feat: Allow name field escape configurable (#4674)
8690ef6 
* feat: Allow name field escape configurable

Add config and modify topic build logic to allow name field escape configurable.

Close #4673

Signed-off-by: bruce <[email protected]>

* build: Upgrade dependency libs

Upgrade go-mod-bootstrap and go-mod-core-contracts.

Close #4673

Signed-off-by: bruce <[email protected]>

---------

Signed-off-by: bruce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow name field escape configurable weichou1229/edgex-go
2 participants
@weichou1229 @cloudxxx8