feat: Allow NameFieldPath configurable #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weichou1229 , how is this a breaking change? Isn't this working around the previous breaking change? |
weichou1229
force-pushed
the
name-escape
branch
from
0c9aab0 to
9717c1c
Compare
weichou1229
changed the title
@lenny-intel You're right, this is not a breaking change for SDK, updated the commit message. |
|
@weichou1229 https://github.com/edgexfoundry/go-mod-bootstrap/tree/v3.1.0-dev.34 is ready |
Allow NameFieldPath configurable by checking whether the NameFieldPathEscape enable. Signed-off-by: bruce <[email protected]>
- Upgrade go-mod-bootstrap to v3.1.0-dev.34 - Upgrade go-mod-core-contracts to v3.1.0-dev.11 Signed-off-by: bruce <[email protected]>
weichou1229
force-pushed
the
name-escape
branch
from
5714e2e to
37d7c82
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1506 +/- ##
==========================================
+ Coverage 46.60% 46.65% +0.04%
==========================================
Files 30 30
Lines 2813 2821 +8
==========================================
+ Hits 1311 1316 +5
- Misses 1403 1406 +3
Partials 99 99
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Allow NameFieldPath configurable by checking whether the NameFieldPathEscape enable.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Related PRs are opened, you can refer to edgexfoundry/edgex-go#4673 (comment) and run services to verify the API.
New Dependency Instructions (If applicable)