-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add EnableNameFieldEscape config #594
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 31 31
Lines 2524 2524
=======================================
Hits 1484 1484
Misses 943 943
Partials 97 97
|
0381c9f
to
1e8b74d
Compare
1e8b74d
to
d9b1415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BREAKING CHANGE: Add EnableNameFieldEscape config on the service level and allow NameFieldEscape configurable Signed-off-by: bruce <[email protected]>
c4ae192
to
7478c47
Compare
recheck |
Upgrade go-mod-core-contracts to v3.1.0-dev.11 version. Signed-off-by: bruce <[email protected]>
7478c47
to
798cb5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BREAKING CHANGE: Add EnableNameFieldEscape config on the service level and allow NameFieldEscape configurable
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Related PRs are opened, you can refer to edgexfoundry/edgex-go#4673 (comment) and run services to verify the API.
New Dependency Instructions (If applicable)