Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add EnableNameFieldEscape config #594

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Sep 6, 2023

BREAKING CHANGE: Add EnableNameFieldEscape config on the service level and allow NameFieldEscape configurable

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Related PRs are opened, you can refer to edgexfoundry/edgex-go#4673 (comment) and run services to verify the API.

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #594 (798cb5d) into main (ff44a32) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files          31       31           
  Lines        2524     2524           
=======================================
  Hits         1484     1484           
  Misses        943      943           
  Partials       97       97           
Files Changed Coverage Δ
config/types.go 12.76% <ø> (ø)
bootstrap/handlers/clients.go 95.78% <100.00%> (ø)

@weichou1229 weichou1229 changed the title feat: Add EnableNameFieldEscape config feat!: Add EnableNameFieldEscape config Sep 6, 2023
config/types.go Show resolved Hide resolved
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BREAKING CHANGE: Add EnableNameFieldEscape config on the service level and allow NameFieldEscape configurable

Signed-off-by: bruce <[email protected]>
@weichou1229
Copy link
Member Author

recheck

Upgrade go-mod-core-contracts to v3.1.0-dev.11 version.

Signed-off-by: bruce <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 6eaa9ae into edgexfoundry:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants