Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synch #531

Merged
merged 119 commits into from
Apr 15, 2024
Merged

Synch #531

merged 119 commits into from
Apr 15, 2024

Conversation

dsmf
Copy link
Contributor

@dsmf dsmf commented Apr 10, 2024 •
edited by ds-jhartmann
Loading

dsmf added 30 commits March 21, 2024 15:45
@dsmf
chore(charts):[#489] Rename chart from irs-helm to item-relationship-…
9cee04c 
…service
@dsmf
chore(charts):[#489] Rename chart from irs-helm to item-relationship-…
cf43611 
…service
@dsmf
Merge branch 'main' into chore/489-rename-helm-chart
0464846
@dsmf
chore(charts):[#489] Rename chart -- update CHANGELOG files
9d213fb
@dsmf
chore(charts): [#489] Fix numeric sorting by version
264aa77
@dsmf
chore(charts): [#489] Fixes
bb134cc 
(tag also changes to "item-relationship-service-x.x.x", therefore we need to rename this too)
@dsmf
Merge branch 'main' into chore/489-rename-helm-chart
b3b26ab
@dsmf
Merge remote-tracking branch 'upstream/chore/489-rename-helm-chart' i…
1c5d09c 
…nto chore/489-rename-helm-chart
@dsmf
Merge pull request #833 from dsmf/chore/489-rename-helm-chart
8ffe948 
Chore/489 rename helm chart
@dsmf
fix(impl): [#199] fixes for incorrect implementation
cd665dd
@dsmf
fix(impl): [#199] Add 500er to OpenApiExamples.java
b697f63
@dsmf
fix(impl): [#199] Add CreatePoliciesResponse
c7bd17d
@dsmf
fix(impl): [#199] Correct CreatePolicyRequest OpenAPI
6c7fd6f
@dsmf
fix(impl): [#199] Add BPN regex constant
f17feda
@dsmf
fix(impl): [#199] Fix OpenAPI
df32eb2
@dsmf
fix(impl): [#199] Update insomnia collection for POST policy
00dfa3c
@dsmf
fix(impl): [#199] Improve variable naming
7e07b49
@dsmf
fix(impl): [#199] Add BPN validator
4a20918
@dsmf
fix(impl): [#199] Fix api doc
5dee36a
@dsmf
fix(impl): [#199] Fix UpdatePolicyRequest attribute naming
d500025
@dsmf
fix(impl): [#199] Fix UpdatePolicyRequest (attribute name and validat…
fba5c64 
…ors)
@dsmf
fix(impl): [#199] PolicyPersistence: return saved policy
bb09996
@dsmf
fix(impl): [#199] Correct updateAllowedPolicy API doc and code format…
01bda79 
…ting
@dsmf
fix(impl): [#199] Fixes, improvements, move of business logic to service
8e89f0d 
By moving business logic from PolicyStoreController to PolicyStoreService the PolicyStoreServiceTest can test all business logic while the PolicyStoreControllerTest can focus on web layer concerns such as parameter validation.

Besides this, tests were structured via Nested in order to group tests for each method together. This helps not to forget about test cases.
@dsmf
fix(impl): [#199] Rename request parameter for GET policies
2be0088
@dsmf
fix(impl): [#199] Code formatting
968b04d
@dsmf
fix(impl): [#199] Remove relicts from move of business logic to service
97122e8
@dsmf
fix(impl): [#199] Add additional validation to avoid wrong API usage
8397352
@dsmf
fix(impl): [#199] Correct IRS collection for PUT policies request
a87a67a
@dsmf
fix(impl): [#199] Fix gitignore
6a75e29
@dsmf dsmf requested a review from ds-jhartmann April 10, 2024 14:25
@ds-jhartmann
Copy link
Contributor

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14259

ds-jhartmann and others added 13 commits April 11, 2024 11:23
@ds-jhartmann
chore(irs-api):[#357] Add json aliases to relationship aspects
66d46ac
@ds-jhartmann
chore(cucumber):[#357] Update expected files
00d8094
@dsmf
fix(impl): [#405] fix ClassCastException
c891082
@ds-jhartmann
Merge pull request #864 from catenax-ng/fix/405-ClassCastException
62b1306 
fix(impl): [#405] fix ClassCastException
@ds-jhartmann
Merge pull request #861 from catenax-ng/chore/fix-cucumber-definitions
faa79e5 
chore(cucumber):[#357] ignore contractAgreementId on expected file co…
@dsmf
fix(impl): [#405] improve readability
f6ac170
@dsmf
Merge branch 'refs/heads/main' into bugfix/405-RestClientExceptions-n…
11129bd 
…ot-handled-correctly
@dsmf
fix(impl): [#405] catch RestClientExceptions
16d6319
@dsmf
fix(impl): [#405] update CHANGELOG.md
a2cb4aa
@ds-ext-kmassalski
feat(impl):[#517] updated insomnia collection
9ed5102
@dsmf
Merge pull request #866 from catenax-ng/bugfix/405-RestClientExceptio…
bd6e811 
…ns-not-handled-correctly

bugfix/405-RestClientExceptions-not-handled-correctly
@ds-ext-kmassalski
feat(impl):[#517] updated insomnia collection
f33d178
@ds-ext-kmassalski
Merge pull request #867 from catenax-ng/feat/517-update-insomnia-coll…
833c6e5 
…ection

feat(impl):[#517] updated insomnia collection
ds-jhartmann
ds-jhartmann approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit e4d7361 into eclipse-tractusx:main Apr 15, 2024
17 of 20 checks passed
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this pull request Jun 13, 2024
@ds-jhartmann
Merge pull request eclipse-tractusx#531 from catenax-ng/feature/TRI-1…
cf8f956 
…523-update-ESS-environment

feat(charts):[TRI-1523] Update IRS to 3.4.0 and EDC to 0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsmf @ds-jhartmann @ds-ext-kmassalski