Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INDUSTRY_CORE] Update Semantic Models of IndustryCore #357

Closed
7 tasks
jzbmw opened this issue Jan 16, 2024 · 17 comments
Closed
7 tasks

[INDUSTRY_CORE] Update Semantic Models of IndustryCore #357

jzbmw opened this issue Jan 16, 2024 · 17 comments
Assignees
@ds-jhartmann
Labels
linked_to_feature Issue is linked to a feature pip12 Issues which are plannen in the PIP 12 event semantic_models semantic_models spill_over Issues which are not finished yet

Comments

@jzbmw
Copy link
Contributor

jzbmw commented Jan 16, 2024 •
edited by mkanal
Loading

As PO ,
I want that the IRS is able to handle the updated semantic models from the industry core,
so that we can provide a stable 24.05 Release .

Blocked

This is blocked until new test data is available

Link

Hints / Details

Outcome / Acceptance Criteria

Acceptance Criteria

  • Aspect Models have been updated
  • JIS, Batch, Software, PartType, PartInstance
  • IRS supports the following mandatory aspect models
  • IRS supports the following optional aspect models
  • Add tests for new aspect models, including shared PartSiteInformationAsBuilt (covered with Mock infrastructure)
  • Update Compatibility Matrix including new supported semantic models
  • Report evidence that industry core semantic models are supported by IRS version
Checked Artefact Version Availability link
AAS
[x] https://jira.catena-x.net/browse/TRI-893 PartAsPlanned 2.0.0 Mandatory PartAsPlanned 2.0.0
[x] SingleLevelBomAsPlanned 3.0.0 Mandatory SingleLevelBomAsPlanned 3.0.0
[ ] INT Test in ERROR https://jira.catena-x.net/browse/TRI-767 SerialPart 3.0.0 Mandatory SerialPart 3.0.0
[ ] INT Test in ERROR https://jira.catena-x.net/browse/TRI-767 Batch 3.0.0 Mandatory Batch 3.0.0
[ ] INT Test in ERROR https://jira.catena-x.net/browse/TRI-767 JustInSequencePart 3.0.0 Mandatory JustInSequencePart 3.0.0
[ ] INT Test in ERROR https://jira.catena-x.net/browse/TRI-767 SingleLevelBomAsBuilt 3.0.0 Mandatory SingleLevelBomAsBuilt 3.0.0
[ ] INT Test in ERROR https://jira.catena-x.net/browse/TRI-767 PartSiteInformationAsBuilt 1.0.0 Integrated in Aspects JustInSequencePart / Batch / SerialPart PartSiteInformationAsBuilt 1.0.0

Out of Scope

  • Preparing Testdata.
@jzbmw jzbmw added this to IRS Jan 16, 2024
@github-project-automation github-project-automation bot moved this to inbox in IRS Jan 16, 2024
@jzbmw jzbmw added BLOCKED Items which are blocked by dependencies pip12 Issues which are plannen in the PIP 12 event DISCUSSION_NEEDED This ticket needs discussion within teammembers labels Jan 16, 2024
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 19, 2024
@mkanal mkanal mentioned this issue Jan 19, 2024
Open
@mkanal mkanal changed the title Update Semantic Models Update Semantic Models of IndustryCore Jan 26, 2024
@mkanal mkanal mentioned this issue Jan 26, 2024
Closed
5 tasks
@mkanal mkanal changed the title Update Semantic Models of IndustryCore [INDUSTRY_CORE] Update Semantic Models of IndustryCore Jan 26, 2024
@mkanal mkanal mentioned this issue Jan 31, 2024
Open
8 tasks
@mkanal
Copy link
Contributor

mkanal commented Feb 14, 2024

@jzbmw currently test data set covers all expected aspect models - this story is ready to implement.

@mkanal mkanal removed the BLOCKED Items which are blocked by dependencies label Feb 19, 2024
@mkanal mkanal moved this from inbox to backlog in IRS Feb 19, 2024
@ds-jhartmann
Copy link
Contributor

@jzbmw @mkanal this is marked as DISCUSSION_NEEDED. Are there still open topics?

@mkanal mkanal removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Mar 5, 2024
@mkanal mkanal moved this from backlog to next in IRS Mar 5, 2024
@jzbmw jzbmw removed their assignment Mar 14, 2024
@mkanal mkanal added the spill_over Issues which are not finished yet label Mar 19, 2024
@ds-jhartmann
Copy link
Contributor

ds-jhartmann commented Mar 22, 2024 •
edited
Loading

This is depending on the latest testdata set which will be updated in #488

Also:
SingleLevelBomAsPlanned is required as 2.0.0 in the Aceptance Criteria, but TDG-43 provides SingleLevelBomAsPlanned 3.0.0 so there is a mismatch here @mkanal

@dsmf dsmf mentioned this issue Mar 22, 2024
Closed
7 tasks
@dsmf
Copy link
Contributor

dsmf commented Mar 22, 2024

blocked by #488

@dsmf dsmf added the BLOCKED Items which are blocked by dependencies label Mar 22, 2024
@mkanal
Copy link
Contributor

mkanal commented Mar 22, 2024 •
edited
Loading

blocked by #488

Please add some more context. Please add BLOCKED label only after an alignment in daily. Thank you very much.

@mkanal mkanal removed the BLOCKED Items which are blocked by dependencies label Mar 22, 2024
@mkanal
Copy link
Contributor

mkanal commented Mar 22, 2024

Removed "BLOCKED" label as there has to be alignment first to get a common understanding about the underlying impediment.

@dsmf
Copy link
Contributor

dsmf commented Mar 22, 2024 •
edited
Loading

Hi @mkanal,

I marked it blocked because of Jaros comment #357 (comment). What else do you need as context?

The BLOCKED label was intended to signal that we should start with the testdata story first, because we won't be able to finish this one without the other (--> limiting WIP).

@mkanal
Copy link
Contributor

mkanal commented Mar 25, 2024 •
edited
Loading

Hi @dsmf
thank you for addressing the issue. The dependency was regarding Industry Core standard 1.0.0. Meanwhile, there is Industry Core in version 2.0.0, with the new aspect versions 3.0.0. So we should directly update to this version. The semantic team has although updated this versions directly in the testdata set. If there is still an impediment, please align on this directly p2p.

@mkanal mkanal added the BLOCKED Items which are blocked by dependencies label Mar 25, 2024
@mkanal mkanal self-assigned this Apr 15, 2024
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(cucumber):[#357] Add expected files for new cucumber tests
89986a6
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(testing):[#357] Add new asPlanned testdata
8be31a6
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(cucumber):[#357] Add expected files for new cucumber tests
3ca8844
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(irs-api):[#357] Add capability to add SAMM models locally
d1fe5a1
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
Merge remote-tracking branch 'refs/remotes/origin/main' into feature/#…
a4e237b 
…357-Update-Semantic-Models-of-IndustryCore

# Conflicts:
#	local/testing/testdata/CX_Testdata_v.1.7.0_PartType.json
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(irs-api):[#357] Ignore padding for locally provided schema files
437c59f
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
chore(docs):[#357] Add Industry Core Models
df41ca3
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
feat(cucumber):[#357] Adjust to latest testdata version
88d5ea9
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
Merge pull request #857 from catenax-ng/feature/#357-Update-Semantic-…
c47d641 
…Models-of-IndustryCore

Feature/#357 update semantic models of industry core
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
chore(cucumber):[#357] ignore contractAgreementId on expected file co…
d2f8834 
…mparison
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
chore(irs-api):[#357] Add json aliases to relationship aspects
66d46ac
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
chore(cucumber):[#357] Update expected files
00d8094
ds-jhartmann added a commit that referenced this issue Apr 15, 2024
@ds-jhartmann
Merge pull request #861 from catenax-ng/chore/fix-cucumber-definitions
faa79e5 
chore(cucumber):[#357] ignore contractAgreementId on expected file co…
@mkanal mkanal added the semantic_models semantic_models label Apr 25, 2024
@mkanal
Copy link
Contributor

mkanal commented May 2, 2024

@dsmf @ds-jhartmann @ds-kgassner
INT Tests https://jira.catena-x.net/browse/TRI-767 https://jira.catena-x.net/browse/TRI-1913 https://jira.catena-x.net/browse/TRI-1914 https://jira.catena-x.net/browse/TRI-704 must be executed successful then this is done.

@ds-jhartmann ds-jhartmann moved this from test to review in IRS May 13, 2024
@ds-jhartmann ds-jhartmann removed their assignment May 13, 2024
@ds-jhartmann
Copy link
Contributor

@mkanal TRI-767 and TRI-704 are not relevant for this issue since they request a entire vehicle. As seen in this test execution TRI-1927, the cucumber test executions were successful at the time.

@mkanal
Copy link
Contributor

mkanal commented May 14, 2024

@ds-jhartmann I could not see test evidence. I will set this to test again.
image

@mkanal mkanal assigned ds-jhartmann and unassigned mkanal May 14, 2024
@mkanal mkanal moved this from review to wip in IRS May 14, 2024
@ds-jhartmann
Copy link
Contributor

As seen here, all relevant Cucumber Tests are successful: https://jira.catena-x.net/browse/TRI-2013
image

@ds-jhartmann ds-jhartmann moved this from wip to review in IRS May 14, 2024
@mkanal mkanal moved this from review to done in IRS May 14, 2024
@mkanal
Copy link
Contributor

mkanal commented May 14, 2024

All tests run successfully. PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed May 14, 2024
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
@ds-jhartmann
chore(charts):[eclipse-tractusx#357] Add local models
6befa08
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
@ds-jhartmann
Merge pull request eclipse-tractusx#858 from catenax-ng/chore/eclipse…
c688a45 
…-tractusx#357-add-local-models

chore(charts):[eclipse-tractusx#357] Add local models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-jhartmann ds-jhartmann

Labels
linked_to_feature Issue is linked to a feature pip12 Issues which are plannen in the PIP 12 event semantic_models semantic_models spill_over Issues which are not finished yet
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dsmf @jzbmw @ds-jhartmann @mkanal