Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tri 387 load and performance tests #199

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Feature/tri 387 load and performance tests #199

merged 9 commits into from
Mar 16, 2023

Conversation

ds-jhartmann
Copy link

  • Added load test module using Gatling
  • Added simple load test scenario

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 15, 2023
View reviewed changes
irs-load-tests/src/test/java/org/eclipse/tractusx/irs/IRSLoadTestSimulation.java
final String clientId = System.getenv("KEYCLOAK_CLIENT_ID");
String body = "grant_type=client_credentials&client_id=" + clientId + "&client_secret=" + clientSecret;
final String irsUrl = System.getenv("IRS_HOST");
final int testCycles = Integer.parseInt(System.getenv("TEST_CYCLES"));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ds-jhartmann ds-jhartmann merged commit 0ab27c9 into main Mar 16, 2023
@ds-jhartmann ds-jhartmann deleted the feature/TRI-387-Load-and-Performance-Tests branch March 16, 2023 09:46
ds-psosnowski added a commit that referenced this pull request Mar 5, 2024
@ds-psosnowski
feat(irs-api):[#199] register policy definition for certain bpnls
8028ac4
ds-psosnowski added a commit that referenced this pull request Mar 5, 2024
@ds-psosnowski
feat(irs-api):[#199] merge and conflicts resolve
1898634
ds-psosnowski added a commit that referenced this pull request Mar 11, 2024
@ds-psosnowski
feat(irs-api):[#199] added changelog entry
c65f58e
ds-psosnowski added a commit that referenced this pull request Mar 12, 2024
@ds-psosnowski
feat(irs-api):[#199] added test
f9a886b
ds-psosnowski added a commit that referenced this pull request Mar 12, 2024
@ds-psosnowski
feat(irs-api):[#199] update
4975d01
ds-psosnowski added a commit that referenced this pull request Mar 13, 2024
@ds-psosnowski
feat(irs-api):[#199] added tests
eba7540
ds-psosnowski added a commit that referenced this pull request Mar 13, 2024
@ds-psosnowski
feat(irs-api):[#199] test clean up
dcdd24e
dsmf added a commit that referenced this pull request Mar 13, 2024
@dsmf
feat(impl): [#199] Harden test and clean method signature
58a3212 
 1) harden test PolicyStoreServiceTest#whenUpdate by asserting that the creation timestamp is not changed and that the validUntil timestamp is changed as expected

 2) clean method signature by moving loop from controller to the service method
dsmf added a commit that referenced this pull request Mar 13, 2024
@dsmf
feat(impl): [#199] Fix warnings
9340fb4
dsmf added a commit that referenced this pull request Mar 13, 2024
@dsmf
feat(impl): [#199] Deduplicate by extraction to findBpnsByPolicyId
05ec245
dsmf added a commit that referenced this pull request Mar 13, 2024
@dsmf
feat(impl): [#199] Avoid too many methods by extraction to helper class
038b85a 
inlcuding test for helper class
dsmf added a commit that referenced this pull request Mar 13, 2024
@dsmf
feat(impl): [#199] Add tests
c999b0a 
- updatePolicies_shouldAddPolicyToEachBpn
- updatePolicies_shouldAddBpnsToEachPolicy
dsmf added a commit that referenced this pull request Mar 14, 2024
@dsmf
feat(impl): [#199] Spelling
f083e90
dsmf added a commit that referenced this pull request Mar 14, 2024
@dsmf
feat(impl): [#199] Spelling
9c5f44d
dsmf added a commit that referenced this pull request Mar 14, 2024
@dsmf
feat(impl): [#199] Spelling
92f551c
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Fixes, improvements, move of business logic to service
8e89f0d 
By moving business logic from PolicyStoreController to PolicyStoreService the PolicyStoreServiceTest can test all business logic while the PolicyStoreControllerTest can focus on web layer concerns such as parameter validation.

Besides this, tests were structured via Nested in order to group tests for each method together. This helps not to forget about test cases.
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Rename request parameter for GET policies
2be0088
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Code formatting
968b04d
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Remove relicts from move of business logic to service
97122e8
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Add additional validation to avoid wrong API usage
8397352
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Correct IRS collection for PUT policies request
a87a67a
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Fix gitignore
6a75e29
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Fix validation and add documentation
21b107c
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] tests
e2ba964
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Correct API doc
09925a4
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Format code
f9400dc
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Fix checkstyle
6e3b488
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] Fix OpenAPI annotation
b86b209
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] add todo concerning OpenAPI response value descript…
78c4246 
…ion for GET policies
dsmf added a commit that referenced this pull request Mar 28, 2024
@dsmf
fix(impl): [#199] fix insomnia collection
25e8259 
- fix Get all policies
- add Get policies for BPN
- fix Create policy body ("payload" with single policy instead of array named "policies"), see #249
dsmf added a commit that referenced this pull request Apr 8, 2024
@dsmf
fix(impl): [#199] update irs-api.yaml
68fe1a6
dsmf added a commit that referenced this pull request Apr 8, 2024
@dsmf
fix(impl): [#199] remove obsolete code
d7e0a33
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] add test
b04026d
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] group constants via interface
06c542a 
reason: better distinguish between configured and registered default policy/policies
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] correct logging
dd14862
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] fix default handling
45fd895 
including:
- additional tests
- improved test naming
- superfluous SuppressWarnings removed
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] fix checkstyle warning (copyright header)
1431c4a
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] fix checkstyle warning (InterfaceIsType)
51c03e2
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] fix IDE warning
7efea9d
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] fix API doc
d8957ad
dsmf added a commit that referenced this pull request Apr 9, 2024
@dsmf
fix(impl): [#199] corrections in irs-api.yaml
7b1b3a3
dsmf added a commit that referenced this pull request Apr 10, 2024
@dsmf
fix(impl): [#199] update irs-api.yaml
77fb94a
dsmf added a commit that referenced this pull request Apr 10, 2024
@dsmf
fix(impl): [#199] code formatting
da16713
dsmf added a commit that referenced this pull request Apr 10, 2024
@dsmf
fix(impl): [#199] fix PMD errors
3ba862f
dsmf added a commit that referenced this pull request Apr 10, 2024
@dsmf
fix(impl): [#199] fix insomnia collection
db75d10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jkreutzfeld ds-jkreutzfeld ds-jkreutzfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-jhartmann @ds-jkreutzfeld