Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioning of contract negotiation and contract agreement for assets #370

Closed
5 of 16 tasks
mkanal opened this issue Jan 18, 2024 · 2 comments
Closed
5 of 16 tasks
Assignees
Labels
linked_to_feature Issue is linked to a feature

Comments

@mkanal
Copy link
Contributor

mkanal commented Jan 18, 2024

As Business app
I want to receive CIDs for negotiated assets OR in case of policy is not valid, the policy of the catalog offer inside a tombstone
so that I am able to request the contract agreement over EDC API using the CID

Link

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  • JobResponse provides ContractAgreementId (CID) for shells and submodels
  • JobResponse provides Tombstone extended with policy information in case of invalid policy
  • New API parameter auditContractNegotiation enables and disables audit functionality
  • Documentation (ARC42, API, Admin manual) is extended explaining the new functionality
  • E2E and INT tests are extended accordingly
  • JobResponse parameter shell/contractAgreementId, submodels.contractAgreementId , tombstones.policy are set to null

Out of Scope

  • ...

Hints / Details

auditContractNegotiation

  • parameter name: auditContractNegotiation
  • parameter value: boolean value
  • parameter default: true
  • parameter description: enables and disables auditing, including provisioning of ContractAgreementId inside submodels and shells objects
  • parameter impacts: enables collection of ContractAgreementId in job processing and provides this information in submodelContainers and ShellContainers as well in Tombstone in case policy does not match or other internal error during EDC communication.
@ds-jhartmann
Copy link
Contributor

ds-jhartmann commented Jan 23, 2024

Planning 2:

  • regarding the policy inside tombstones: adding it directly might not be the best solution. Consider a more generic approach (e.g. Object Map)
  • Contract agreement id can be obtained from decoded EndpointDatareference.authCode

@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Jan 25, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Jan 25, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to review in IRS Feb 1, 2024
@jzbmw jzbmw moved this from review to done in IRS Feb 5, 2024
@jzbmw jzbmw moved this from done to review in IRS Feb 5, 2024
@jzbmw jzbmw moved this from review to done in IRS Feb 6, 2024
@jzbmw jzbmw closed this as completed Feb 6, 2024
@ds-alexander-bulgakov
Copy link
Contributor

Tavern-tests were created, PR #760 has been merged.

ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
…act-agreement-id

feat(impl):[#370] impl adding contract agreement id
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
…-for-auditContractNegotiation

feat(testing):#370 added tavern tests for auditContractNegotiation
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
ds-jhartmann added a commit that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

6 participants