Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide EDC Contract API for FE #420

Assignees
Labels
backend Backend related issues data_souvereignty Issues refering to the catena-X data sovereignty principals hardening measurements to increase resiliency spillover temporary label for spill over

Comments

@ds-jleyh
Copy link
Contributor

ds-jleyh commented Dec 20, 2023

As an API Requester of Trace-X
I want to provide data of contracts
so that users can see contracts to their assets

Hints / Details

Clarification

Currently there is a technical question which needs to be answered before we can estimate this story:

Initial we thought we can retrieve the contractAgreementId based on the globalAssetId. Therefore we need a relation or some kind of a mapping between those variables. Plan is to have a small technical discussion with two developers. Lucas Capellino / Maximilian Wesener / Janice Leyh to clarify how to address this question. Should be ready for estimation for next refinement session on 9th January.

Acceptance Criteria

  • the attributes contract ID, Counter party address, creation date, state and policy are provided
  • the processed data of the management API can be accessed through a new API: GET/contracts/{assetID}
  • the new API is documented
  • the new API makes 2 Requests to get attributes: POST/management/v2/contractagreements/request & GET /management/v2/contractagreements/{ContractAgreementId}/negotiation
  • payload of the requests is mapped into a domain model

Out of Scope

  • Attribute EndDate: At the moment, the end date can't be taken from the edc, because the edc doesn't manage usage policies.
@ds-jleyh
Copy link
Contributor Author

couldn't assign @ds-lcapellino

@jzbmw jzbmw changed the title 🔴[DATA_SOVEREIGNTY][CONTRACT_MANAGEMENT][BE] Provide API for FE Provide API for FE Jan 8, 2024
@jzbmw jzbmw added backend Backend related issues hardening measurements to increase resiliency labels Jan 8, 2024
@jzbmw jzbmw changed the title Provide API for FE Provide EDC Contract API for FE Jan 8, 2024
@jzbmw
Copy link
Contributor

jzbmw commented Jan 8, 2024

I also could not do that

@jzbmw jzbmw added the data_souvereignty Issues refering to the catena-X data sovereignty principals label Feb 1, 2024
@jzbmw
Copy link
Contributor

jzbmw commented Feb 1, 2024

@jzbmw jzbmw moved this from inbox to backlog in Trace-X Feb 1, 2024
@mkanal mkanal added the BLOCKED Issues are blocked by other issues label Feb 6, 2024
@jzbmw jzbmw removed the BLOCKED Issues are blocked by other issues label Feb 20, 2024
@jzbmw jzbmw moved this from backlog to next in Trace-X Feb 20, 2024
@ds-lcapellino ds-lcapellino self-assigned this Feb 21, 2024
@ds-lcapellino ds-lcapellino moved this from next to wip in Trace-X Feb 21, 2024
@ds-lcapellino
Copy link
Contributor

Open questions:

  1. mix as-planned and as-built assets in contract view?
  2. Default view in contracts on first click on page?

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Mar 8, 2024

Updated acceptance criteria

  • the attributes contract ID, Counter party address, creation date and state are provided
  • the processed data of the management API can be accessed through a new API: POST/contracts with a pageable and filterable Object
  • the new API is documented
  • the new API makes 2 Requests to get attributes: POST/management/v2/contractagreements/request & GET /management/v2/contractagreements/{ContractAgreementId}/negotiation
  • payload of the requests is mapped into a domain model

@ds-crehm
Copy link
Contributor

Tested with the provided Insomnia collection. Works for me.
Sorting and filtering works only with assetID and creationDate of the asset. Sorting and filtering for the user will be handled in the frontend story #421

@ds-crehm ds-crehm moved this from test to review in Trace-X Mar 13, 2024
@ds-crehm ds-crehm assigned jzbmw and unassigned ds-lcapellino and ds-crehm Mar 13, 2024
@ds-lcapellino ds-lcapellino self-assigned this Mar 18, 2024
@jzbmw jzbmw moved this from review to done in Trace-X Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues data_souvereignty Issues refering to the catena-X data sovereignty principals hardening measurements to increase resiliency spillover temporary label for spill over
Projects
Status: done
5 participants