Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate callbacks for jobs received #755

Closed
ds-lcapellino opened this issue Jul 4, 2024 · 2 comments
Closed

Duplicate callbacks for jobs received #755

ds-lcapellino opened this issue Jul 4, 2024 · 2 comments
Assignees
@ds-jhartmann
Labels
bug Something isn't working R24.8

Comments

@ds-lcapellino
Copy link
Contributor

cleanup_githubaction_duplicate_errors.txt

Description

Current behaviour

We started 23 Jobs for 23 assets but received 36 callbacks. Which resulted in duplicate key exceptions.

Synchronizing assets for globalAssetId: urn:uuid:d8030bbf-a874-49fb-b2e1-7610f0ccad12
Synchronizing assets for globalAssetId: urn:uuid:4e390dab-707f-446e-bfbe-653f6f5b1f37
Synchronizing assets for globalAssetId: urn:uuid:4a5e9ff6-2d5c-4510-a90e-d55af3ba502f
Synchronizing assets for globalAssetId: urn:uuid:7c7d5aec-b15d-491c-8fbd-c61c6c02c69a
Synchronizing assets for globalAssetId: urn:uuid:6ec3f1db-2798-454b-a73f-0d21a8966c74
Synchronizing assets for globalAssetId: urn:uuid:1be6ec59-40fb-4993-9836-acb0e284fa02
Synchronizing assets for globalAssetId: urn:uuid:1be6ec59-40fb-4993-9836-acb0e284fa01
Synchronizing assets for globalAssetId: urn:uuid:6b2296cc-26c0-4f38-8a22-092338c36e22
Synchronizing assets for globalAssetId: urn:uuid:1be6ec59-40fb-4993-9836-acb0e284fa03
Synchronizing assets for globalAssetId: urn:uuid:0733946c-59c6-41ae-9570-cb43a6e43842
Synchronizing assets for globalAssetId: urn:uuid:44347dec-21d1-47aa-b2a7-f959bf9d424b
Synchronizing assets for globalAssetId: urn:uuid:1233b405-5ac8-4867-93f8-6fdf37733737
Synchronizing assets for globalAssetId: urn:uuid:bcfae197-40fa-4be0-821d-5c1873a1b7c2
Synchronizing assets for globalAssetId: urn:uuid:254604ab-2153-45fb-8cad-54ef09f4070e
Synchronizing assets for globalAssetId: urn:uuid:e3b2f5e2-5be5-4ea6-98f0-6876de0fca4f
Synchronizing assets for globalAssetId: urn:uuid:0733946c-59c6-41ae-9570-cb43a6e4da01
Synchronizing assets for globalAssetId: urn:uuid:aad27ddb-43aa-4e42-98c2-01e529ef127c
Synchronizing assets for globalAssetId: urn:uuid:e5c96ab5-896a-482c-8761-efd74777ca98
Synchronizing assets for globalAssetId: urn:uuid:4f7b1cf2-a598-4027-bc78-63f6d8e55699
Synchronizing assets for globalAssetId: urn:uuid:bee5614f-9e46-4c98-9209-61a6f2b2a7fc
Synchronizing assets for globalAssetId: urn:uuid:4518c080-14fb-4252-b8de-4362d615868d
Synchronizing assets for globalAssetId: urn:uuid:3cdd2826-5df0-4c7b-b540-9eeccecb2301
Synchronizing assets for globalAssetId: urn:uuid:68904173-ad59-4a77-8412-3e73fcafbd8b

callbacks received:

/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback
/api/irs/job/callback

Expected behavior

We expected to only receive 23 callbacks. 1 for each started job.

Steps to reproduce the Bug

trigger the asset synchronization at Trace-X you should see more callbacks than jobs started. For further details please see attached log.
@ds-lcapellino ds-lcapellino added the bug Something isn't working label Jul 4, 2024
@github-project-automation github-project-automation bot moved this to inbox in IRS Jul 4, 2024
@ds-lcapellino ds-lcapellino mentioned this issue Jul 9, 2024
Closed
2 tasks
@mkanal mkanal moved this from inbox to backlog in IRS Jul 9, 2024
ds-jhartmann added a commit that referenced this issue Jul 17, 2024
@ds-jhartmann
chore(docs): add #755 to known knowns for 5.3.0
e523f43
@mkanal mkanal added the R24.8 label Jul 22, 2024
@ds-jhartmann ds-jhartmann self-assigned this Jul 29, 2024
@ds-jhartmann ds-jhartmann moved this from backlog to next in IRS Jul 29, 2024
@ds-jhartmann ds-jhartmann moved this from next to wip in IRS Jul 29, 2024
ds-jhartmann added a commit that referenced this issue Aug 1, 2024
@ds-jhartmann
fix(irs-api):[#755] fix job callbacks called multiple times after com…
eb6794e 
…pletion
@ds-jhartmann ds-jhartmann mentioned this issue Aug 1, 2024
Merged
2 tasks
@ds-jhartmann
Copy link
Contributor

Fixed job callbacks called multiple times after completion in #862

ds-jhartmann added a commit that referenced this issue Aug 1, 2024
@ds-jhartmann
fix(irs-api):[#755] use inline StringUtils.isblank for better readabi…
73d973f 
…lity
ds-jhartmann added a commit that referenced this issue Aug 1, 2024
@ds-jhartmann
fix(irs-api):[#755] removed unnecessary comparisons, added description
072a0f1
ds-jhartmann added a commit that referenced this issue Aug 2, 2024
@ds-jhartmann
Merge pull request #862 from eclipse-tractusx/fix/755-duplicate-callb…
513bc56 
…acks

fix(irs-api):[#755] fix job callbacks called multiple times after com…
@ds-jhartmann ds-jhartmann moved this from wip to test in IRS Aug 2, 2024
@ds-jhartmann
Copy link
Contributor

Tested by https://github.com/eclipse-tractusx/item-relationship-service/blob/main/irs-api/src/test/java/org/eclipse/tractusx/irs/IrsWireMockIntegrationTest.java#L200

@ds-jhartmann ds-jhartmann moved this from test to review in IRS Aug 5, 2024
@mkanal mkanal moved this from review to done in IRS Aug 6, 2024
@mkanal mkanal closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-jhartmann ds-jhartmann

Labels
bug Something isn't working R24.8
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ds-jhartmann @mkanal @ds-lcapellino