Refactor (bpdm) - Conversion of properties files to YML #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
force-pushed
the
feat/application_to_yaml
branch
from
452616c to
1cf1ea2
Compare
nicoprow
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks good to me.
Please not that this pull request contributes to #572 but it does not solve it completely. We would need follow-up pull requests for renaming the paths for permissions and introduce separate auth yaml files for the clients.
nicoprow
requested changes
Nov 20, 2023
…ange of some properties
alexsilva-CGI
force-pushed
the
feat/application_to_yaml
branch
from
1cf1ea2 to
f64fbaa
Compare
This was referenced Nov 23, 2023
nicoprow
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, application properties we're converted to YML and some properties name path's we're change accordingly.
Solve #572 and #567
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: