Refactor (bpdm) - Creation of Auth YML's and Path changes #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Nov 29, 2023
alexsilva-CGI
force-pushed
the
refactor/properties_structure
branch
from
a3762f6 to
cd02024
Compare
nicoprow
requested changes
Dec 7, 2023
There was a problem hiding this comment.
I gave some feedback exemplary for the Dummy-Bridge configuration. But the same feedback counts for all the other applications as well.
Everything that was moved under permission I would put back to security and instead move the properties for authorities/roles under there.
nicoprow
requested changes
Dec 20, 2023
bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/config/SecurityConfig.kt
Outdated
Show resolved
Hide resolved
alexsilva-CGI
force-pushed
the
refactor/properties_structure
branch
from
02494e3 to
0fc7fa9
Compare
|
Hello @nicoprow, I believe I did the required chances. Is there anything missing? Thanks |
nicoprow
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves remaining points raised on PR #623.
Solve #572
Should be merged only after #623 conclusion.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: