Refactor (bpdm) - DEBUG Logging Messages and Logging Patterns #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
force-pushed
the
feat/logging_patterns
branch
from
7ecd5fd to
be25e54
Compare
nicoprow
reviewed
Nov 28, 2023
alexsilva-CGI
force-pushed
the
feat/logging_patterns
branch
from
be25e54 to
b879075
Compare
nicoprow
requested changes
Nov 29, 2023
alexsilva-CGI
force-pushed
the
feat/logging_patterns
branch
from
b879075 to
6722e38
Compare
nicoprow
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Pattern looks good now.
But please remove the logging overwrite in the application-auth. We don't need a separate logging behaviour for the auth profile. It can just take the default properties.
After that, please rebase and it would be ready from my opinion.
alexsilva-CGI
force-pushed
the
feat/logging_patterns
branch
from
6722e38 to
72e32a0
Compare
nicoprow
approved these changes
Dec 6, 2023
nicoprow
requested changes
Dec 6, 2023
There was a problem hiding this comment.
@alexsilva-CGI please fix the conflicts that resulted from the previous merges to main
… Services and added logging and logging patterns on application yml's
alexsilva-CGI
force-pushed
the
feat/logging_patterns
branch
from
72e32a0 to
217f311
Compare
nicoprow
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, DEBUG Logging Messages to Services which didn't have them before we're added. Also, logging Patterns in the application.yml we're added.
Solve #566 and #565
Should be merged only after #623 PR
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: