feat(generic bpm): #384 Gate API: Create input endpoints for generic data model #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfkaeser
suggested changes
Aug 31, 2023
bpdm-gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/GateBusinessPartnerApi.kt
Outdated
Show resolved
Hide resolved
bpdm-gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/GateBusinessPartnerApi.kt
Outdated
Show resolved
Hide resolved
bpdm-gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/GateBusinessPartnerApi.kt
Outdated
Show resolved
Hide resolved
|
Can you please refer in the PR description to the issue, like "Solves #..." ? |
bpdm-gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/GateBusinessPartnerApi.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/BusinessPartnerIdentifierDto.kt
Show resolved
Hide resolved
...gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/BusinessPartnerStateDto.kt
Outdated
Show resolved
Hide resolved
martinfkaeser
suggested changes
Aug 31, 2023
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/IBaseBusinessPartnerInputDto.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/IBaseBusinessPartnerInputDto.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/IBaseBusinessPartnerInputDto.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/IBaseBusinessPartnerInputDto.kt
Show resolved
Hide resolved
|
I just commented about some naming issues, but content-wise it looks good! |
rainer-exxcellent
force-pushed
the
feat/input-endpoints-generic-bpm
branch
from
2b2b015 to
a84805a
Compare
.../main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/request/BusinessPartnerInputRequest.kt
Show resolved
Hide resolved
.../src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/BusinessPartnerPostalAddressDto.kt
Outdated
Show resolved
Hide resolved
rainer-exxcellent
force-pushed
the
feat/input-endpoints-generic-bpm
branch
2 times, most recently
from
5b3eca5 to
e773e01
Compare
nicoprow
requested changes
Sep 8, 2023
|
|
||
| @get:Schema(description = "Address of the official seat of this business partner.") | ||
| val postalAddress: BusinessPartnerPostalAddressDto | ||
|
|
There was a problem hiding this comment.
Business Partner Input is missing the L/S/A BPN fields as described in #382. I'm aware that the OpenAPI snippet for the generic input endpoint description is not up-to-date on this matter and will add it there as well.
Why are the fields needed?
The service provider for the cleaning service will be supported by this information. Also, since especially Sites are hard to infer automatically, it is one of the only ways for a sharing member to tell the cleaning service that an address belongs to a certain existing site.
There was a problem hiding this comment.
I suggest we move this change to a separate issue in order to not block depending issues for too long.
There was a problem hiding this comment.
Alright, I will put this down in the issue. So we can create a pull request later on
.../main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/request/BusinessPartnerInputRequest.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/IBaseBusinessPartnerInputDto.kt
Outdated
Show resolved
Hide resolved
…nts for generic business partner
…nts for generic business partners - Comments from the review incorporate
…nts for generic business partners - add enum for AddressType
martinfkaeser
force-pushed
the
feat/input-endpoints-generic-bpm
branch
from
f66c16d to
6369339
Compare
…nts for generic business partners - add enum AddressType to open api
martinfkaeser
force-pushed
the
feat/input-endpoints-generic-bpm
branch
from
6369339 to
73f89b2
Compare
nicoprow
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created endpoints for uploading and searching generic business partner.
Solves
#384
At the moment the address are in the "old" style. We have to refactor them when the following pull request was merged:
Refactor: Nested logistic address DTOs #408