Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generic bpm): #384 Gate API: Create input endpoints for generic data model #419
feat(generic bpm): #384 Gate API: Create input endpoints for generic data model #419
Changes from all commits
dd04fb1
e3e7a05
ce31453
73f89b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Business Partner Input is missing the L/S/A BPN fields as described in #382. I'm aware that the OpenAPI snippet for the generic input endpoint description is not up-to-date on this matter and will add it there as well.
Why are the fields needed?
The service provider for the cleaning service will be supported by this information. Also, since especially Sites are hard to infer automatically, it is one of the only ways for a sharing member to tell the cleaning service that an address belongs to a certain existing site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we move this change to a separate issue in order to not block depending issues for too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will put this down in the issue. So we can create a pull request later on