Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate API: Create Input Endpoints for Generic Business Partner #384

Closed
2 tasks done
Tracked by #382
nicoprow opened this issue Aug 10, 2023 · 6 comments
Closed
2 tasks done
Tracked by #382

Gate API: Create Input Endpoints for Generic Business Partner #384

nicoprow opened this issue Aug 10, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicoprow
Copy link
Contributor

nicoprow commented Aug 10, 2023

As a sharing member I may not know which business partner type my record has. I want to share my business partner record in a generic way without needing to pre-determine its type. Which business partner type it is should be the result of the output data in the sharing process.

For this we need endpoints for the input stage that accept and deliver business partners in a generic model.

Acceptance Criteria:

  • Endpoint for uploading several business partners in a generic model
  • Endpoint for querying several business partners by external id and returning them in a generic model

This relates to the generic business partner model discussed in #382

image

Redoc Rendering

Tasks

  • Create endpoints in Gate API module
  • Add optional BPN fields to API model as depictied in the OpenAPI snippet
@nicoprow nicoprow added the enhancement New feature or request label Aug 10, 2023
@rainer-exxcellent
Copy link
Contributor

In the Open-API snippet the put request returns an array of BusinessPartnerInputResponse in all other endpoints which creates an object we simple return an HTTP status codes.

Is this correct?

rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Aug 31, 2023
@fabiodmota
Copy link
Contributor

looks good for me , and about the returning object at least is according to the diagram variant 1 when the upsert is done

image

rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 5, 2023
…nts for generic business partners

- Comments from the review incorporated
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 5, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 5, 2023
…nts for generic business partners

- Comments from the review incorporated
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 6, 2023
…nts for generic business partners

- Comments from the review incorporated
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 6, 2023
…nts for generic business partners

- Comments from the review incorporated
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 7, 2023
…nts for generic business partners

- Comments from the review incorporated
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 7, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Sep 7, 2023
…nts for generic business partners

- Comments from the review incorporate
martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 7, 2023
…nts for generic business partners

- Comments from the review incorporated
martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 8, 2023
martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 8, 2023
…nts for generic business partners

- Comments from the review incorporate
martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 8, 2023
…nts for generic business partners

- Comments from the review incorporated
martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 8, 2023
…nts for generic business partners

- Comments from the review incorporated
nicoprow added a commit that referenced this issue Sep 8, 2023
feat(generic bpm): #384 Gate API: Create input endpoints for generic data model
@nicoprow
Copy link
Contributor Author

nicoprow commented Sep 8, 2023

The generic input business partner should also have BPN fields for Legal Entity, Site and Address as is depicted in #384

martinfkaeser pushed a commit to catenax-ng/tx-bpdm that referenced this issue Sep 8, 2023
…nts for generic business partners

- Comments from the review incorporated
@martinfkaeser
Copy link
Contributor

@nicoprow
Is it correct that for BusinessPartnerIdentifier DTO only the type is required, but not the value (see Redoc)?
For LegalEntityIdentifier DTO both type and value are required.

@nicoprow
Copy link
Contributor Author

@nicoprow Is it correct that for BusinessPartnerIdentifier DTO only the type is required, but not the value (see Redoc)? For LegalEntityIdentifier DTO both type and value are required.

You are right, that was an oversight. I have corrected it in the proposal.

@nicoprow
Copy link
Contributor Author

Added a task list with showing the open topics of BPN fields in the Input DTO

@martinfkaeser martinfkaeser self-assigned this Sep 19, 2023
@martinfkaeser martinfkaeser moved this to 🏗 In progress in BPDM Kanban Sep 19, 2023
@martinfkaeser martinfkaeser moved this from 🏗 In progress to 👀 In review in BPDM Kanban Sep 20, 2023
@nicoprow nicoprow moved this from 👀 In review to ✅ Done in BPDM Kanban Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants